Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spawning threads from electron ASAR file #425

Open
hgossler opened this issue Apr 5, 2022 · 1 comment
Open

Support spawning threads from electron ASAR file #425

hgossler opened this issue Apr 5, 2022 · 1 comment
Labels

Comments

@hgossler
Copy link

hgossler commented Apr 5, 2022

In pull request 226 you added code that modifies paths containing the string .asar because worker files could only be used if they were not packaged in an ASAR file.

In the meantime, the electron team added support for working with workers bundled in ASAR files. However, the patch in 226 does not allow us to bundle worker scripts because the path is always rewritten to point to the unpacked directory.

Can we add an option to bypass any modifications to the scriptPath argument? Thank you for your time.

@andywer
Copy link
Owner

andywer commented Apr 9, 2022

Great point and thanks for sharing!

You can prepare a PR if you've got some time for it. Maybe it makes sense to check if we are in an electron app and if so what version and disable the existing workaround if it's a new electron version with fixed ASAR support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants