Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that extract-text block can take an options object #237

Open
vlad-zhukov opened this issue Oct 31, 2017 · 3 comments
Open

Document that extract-text block can take an options object #237

vlad-zhukov opened this issue Oct 31, 2017 · 3 comments

Comments

@vlad-zhukov
Copy link
Collaborator

vlad-zhukov commented Oct 31, 2017

It works right now, but isn't mentioned anywhere.

@andywer
Copy link
Owner

andywer commented Nov 1, 2017

It cannot... 🤔

There is the documented parameter for the output file and there is one undocumented parameter for passing a fileType string.

The fileType parameter is merely there for backwards-compatibility to early v1.0-alpha versions of webpack-blocks.

Maybe you have been looking at the code of an outdated extract-text block version?

@vlad-zhukov
Copy link
Collaborator Author

The ETP takes 1 argument that is either a filename (as a string) or an options object. Currently the block supports both syntaxes – extractText('file.css') and extractText({filename: 'file.css', allChunks: true}) – (see the source code) but only the first usage is documented.

@andywer
Copy link
Owner

andywer commented Nov 1, 2017

Ahhh, now I get what you mean :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants