Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validators should be run on JS folders only #426

Open
acarstoiu opened this issue Jun 22, 2016 · 4 comments
Open

Validators should be run on JS folders only #426

acarstoiu opened this issue Jun 22, 2016 · 4 comments

Comments

@acarstoiu
Copy link

In a JS project's properties there's an Include Path section which among others allows one to set the source folders. Here I have a js folder listed as source folder, with the exclusion */node_modules (it's a Node.js project).

The problem is that folder js/xyz/node_modules is scanned by JSHint for errors, when it should not be (which is annoying, those are third party modules). I also tried excluding this folder specifically, but it doesn't have any effect. It looks like tern does not take into account exclusions specified in on source folders.
I have not tested if inclusions are observed.

@acarstoiu
Copy link
Author

Forgot to say I'm using the latest release, 1.2.0.

@angelozerr
Copy link
Owner

You must use **/node_modules/* as pattern.

@acarstoiu
Copy link
Author

This does the trick for tern, but has side effects with JSDT because the pattern **/node_modules/* only excludes files, not folders.

@angelozerr
Copy link
Owner

Sorry I have not understood. I suggest you that you share a little project with your problem and tell me which files causes problems. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants