Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column numbers are off by one #294

Closed
rafaelss95 opened this issue Jan 14, 2021 · 2 comments
Closed

Column numbers are off by one #294

rafaelss95 opened this issue Jan 14, 2021 · 2 comments

Comments

@rafaelss95
Copy link
Member

As reported in mgechev/codelyzer#859, #205 (comment) and #269 (comment), column numbers are off by one.

Sample:

<a href="http://example.com">{{ getInfo() }}</a>
~~~~~~~~~


I noticed that we have a hacky way to handle this in no-negated-async:

const additionalOffset = isInterpolation(type) ? -1 : 0;
and
const additionalStartOffset = isInterpolation(type) ? -2 : -1;
const additionalEndOffset = isInterpolation(type) ? -1 : 0;

@drakenfly
Copy link

This is related to #292

If you turn on preserveWhitespaces, this off-by-one is resolved.

@JamesHenry
Copy link
Member

I'll migrate @rafaelss95 comment to that issue, I have reported it to the Angular tooling team and asked for a process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants