Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Suggested improvements for documentation #1

Open
torfmaster opened this issue Apr 23, 2021 · 1 comment
Open

[BUG] Suggested improvements for documentation #1

torfmaster opened this issue Apr 23, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@torfmaster
Copy link

Hi, thanks for creating this great library. There are some points I'd like to be documented:

Unimplemented Components

Some of the components are not yet implemented

  • drawer is implemented however unusable due to unimplemented DrawerAppContent
  • top-app-bar-fixed is unimplemented

I guess there are more components missing in that manner contradictiing the docs.

Usage

It might be helpful to document a basic use, e.g. how to retrieve css+js. One option might be to recommend using unpkg package registry:

    <link
      href="https://unpkg.com/material-components-web@latest/dist/material-components-web.min.css"
      rel="stylesheet"
    />

    <script src="https://unpkg.com/material-components-web@latest/dist/material-components-web.min.js"></script>

What do you think? I might just do the changes and file a PR if that is desired.

@torfmaster torfmaster added the bug Something isn't working label Apr 23, 2021
@dudochkin-victor
Copy link
Member

Hi, thanks for the reply.
I would like it if you did PR.
Because this is very important for the project. To increase the number of contributors. We just don't have enough time for everything. So far, every effort has been made to make color processing more professional and to make the project truly platform-agnostic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants