Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Autofocus is not working in modals #6289

Closed
suvjunmd opened this issue Oct 13, 2016 · 7 comments
Closed

Autofocus is not working in modals #6289

suvjunmd opened this issue Oct 13, 2016 · 7 comments

Comments

@suvjunmd
Copy link

suvjunmd commented Oct 13, 2016

Bug description:

Autofocus is not working in modals. The problem appeared in version 2.2.0, and is missing in 2.1.3.

Link to minimally-working plunker that reproduces the issue:

https://plnkr.co/edit/lnaWCwMQoD0qamWyEhD2?p=preview

Version of Angular, UIBS, and Bootstrap

Angular: 1.5.8
UIBS: 2.2.0
Bootstrap: 3.3.7

@motohead400
Copy link

motohead400 commented Nov 1, 2016

Can confirm--I had the same problem with 2.2.0. Changed to 2.1.3 and autofocus now works.

@nstuyvesant
Copy link

Same here.

@nstuyvesant
Copy link

Sorry - just a clarification... I went back to 2.1.4 (not 2.1.3) from 2.2.0 to resolve the issue.

@brion-fuller
Copy link

I have noticed and issue which probably relatives to this. But notice in 2.2.0 the modal automatically focuses on the first tab-able element. This did not occur in 2.1.4.

@nstuyvesant
Copy link

Seems that the focus goes to the close button (which probably is the first tab-able element). Perhaps this was related to the change to make the dialogs more accessible? See the change on f9f7e02 - src/modal/modal.js line 649 (newly added).

@dgsmith2
Copy link

dgsmith2 commented Jan 5, 2017

It appears this was fixed in #6295

@suvjunmd
Copy link
Author

suvjunmd commented Feb 4, 2017

Fixed in 2.3.1

@suvjunmd suvjunmd closed this as completed Feb 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants