Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: angular-ui/ui-router
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.0.3+hybrid-2.0.0-4
Choose a base ref
...
head repository: angular-ui/ui-router
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.0.4
Choose a head ref
  • 5 commits
  • 6 files changed
  • 2 contributors

Commits on May 17, 2017

  1. Added ')' on uiCanExit example (#3442)

    Roger Pedrós Villorbina authored and christopherthielen committed May 17, 2017
    Copy the full SHA
    f122d78 View commit details

Commits on Jun 9, 2017

  1. Copy the full SHA
    e02262d View commit details
  2. fix(uiSrefActive): Avoid "Possibly unhandled rejection" in console

    - Added a .catch() clause to the promise handler
    
    Closes #3404
    Closes #3309
    christopherthielen committed Jun 9, 2017
    Copy the full SHA
    5c09e28 View commit details
  3. Copy the full SHA
    91e9c7e View commit details
  4. Release 1.0.4

    christopherthielen committed Jun 9, 2017
    Copy the full SHA
    0ac932a View commit details
Showing with 37 additions and 5 deletions.
  1. +28 −0 CHANGELOG.md
  2. +1 −1 bower.json
  3. +1 −1 package.json
  4. +5 −1 scripts/artifact_tagging.js
  5. +1 −1 src/directives/stateDirectives.ts
  6. +1 −1 src/interface.ts
28 changes: 28 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,31 @@
<a name="1.0.4"></a>
## [1.0.4](https://github.com/angular-ui/ui-router/compare/1.0.3...1.0.4) (2017-06-09)


### Bug Fixes

* **bundle:** work around rollup bug https://github.com/rollup/rollup/issues/1322 ([befb50a](https://github.com/angular-ui/ui-router/commit/befb50a))
* **uiSrefActive:** Avoid "Possibly unhandled rejection" in console ([5c09e28](https://github.com/angular-ui/ui-router/commit/5c09e28))



### @uirouter/core changes
## [5.0.4](https://github.com/ui-router/core/compare/5.0.3...5.0.4) (2017-06-09)


### Bug Fixes

* **future:** Allow future states to specify a `parent:` ([828fe1b](https://github.com/ui-router/core/commit/828fe1b))
* **view:** only sync views which are of the same name *and type* ([c48da4a](https://github.com/ui-router/core/commit/c48da4a))


### Features

* **invalidTransition:** Better error messaging when param values are invalid ([2a15d1a](https://github.com/ui-router/core/commit/2a15d1a))
* **trace:** Trace view synchronization. Allow trace.enable(...string) ([284392d](https://github.com/ui-router/core/commit/284392d))



<a name="1.0.3"></a>
## [1.0.3](https://github.com/angular-ui/ui-router/compare/1.0.1...1.0.3) (2017-05-07)

2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"name":"angular-ui-router","description":"State-based routing for AngularJS","license":"MIT","main":"./release/angular-ui-router.js","dependencies":{"angular":">= 1.2.0"},"ignore":["**/.*","**/tsconfig.json","**/tsconfig.typedoc.json","**/webpack.config.js","**/node_modules","package.json","scripts","test","src"],"version":"1.0.3"}
{"name":"angular-ui-router","description":"State-based routing for AngularJS","license":"MIT","main":"./release/angular-ui-router.js","dependencies":{"angular":">= 1.2.0"},"ignore":["**/.*","**/tsconfig.json","**/tsconfig.typedoc.json","**/webpack.config.js","**/node_modules","package.json","scripts","test","src"],"version":"1.0.4"}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@uirouter/angularjs",
"description": "State-based routing for AngularJS 1.x",
"version": "1.0.3",
"version": "1.0.4",
"scripts": {
"clean": "shx rm -rf lib lib-esm _doc build release *.log",
"build": "tsc && tsc -m es6 --outDir lib-esm && npm run fixdts",
6 changes: 5 additions & 1 deletion scripts/artifact_tagging.js
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ if (isNarrow && readlineSync.keyInYN('Widen @uirouter/core dependency from ' + c
widen = false;
}

let tagname = `${version}+hybrid-${hybridVersion}`;
let tagname = `${version}-hybrid-${hybridVersion}`;
tagname += readlineSync.question(`Suffix for tag ${tagname} (optional)?`);

if (!readlineSync.keyInYN(`Ready to publish ${tagname} tag?`)) {
@@ -36,12 +36,16 @@ util.ensureCleanMaster('master');
_exec(`git checkout -b ${tagname}-prep`);

pkg.dependencies['@uirouter/core'] = widenedDep;
pkg.version = tagname;

fs.writeFileSync("package.json", JSON.stringify(pkg, undefined, 2));
_exec('git commit -m "Widening @uirouter/core dependency range to ' + widenedDep + '" package.json');

_exec('npm run package');

_exec(`git add --force lib lib-esm release package.json`);
_exec(`git rm yarn.lock`);

_exec(`git commit -m 'chore(*): commiting build files'`);
_exec(`git tag ${tagname}`);
_exec(`git push -u origin ${tagname}`);
2 changes: 1 addition & 1 deletion src/directives/stateDirectives.ts
Original file line number Diff line number Diff line change
@@ -564,7 +564,7 @@ uiSrefActive = ['$state', '$stateParams', '$interpolate', '$uiRouter',
};

function updateAfterTransition(trans) {
trans.promise.then(update);
trans.promise.then(update, noop);
}

$scope.$on('$stateChangeSuccess', update);
2 changes: 1 addition & 1 deletion src/interface.ts
Original file line number Diff line number Diff line change
@@ -695,7 +695,7 @@ export interface Ng1Controller {
* this.originalData = angular.copy(this.data);
*
* this.uiCanExit = function() {
* if (!angular.equals(this.data, this.originalData) {
* if (!angular.equals(this.data, this.originalData)) {
* // Note: This could also return a Promise and request async
* // confirmation using something like ui-bootstrap $modal
* return window.confirm("Data has changed. Exit anyway and lose changes?");