Skip to content

Commit

Permalink
feat(@schematics/angular): enable lazy loading on the server for new …
Browse files Browse the repository at this point in the history
…projects

With this change, lazy-loading on the server becomes enabled out of the box for new projects. This is because webpack will only split ES6 imports into separate chunks. However when using commonjs all lazy loaded paths will be concatenated into the main.js file.
  • Loading branch information
alan-agius4 authored and kyliau committed Apr 2, 2020
1 parent bd789f5 commit a2b158b
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"extends": "./<%= tsConfigExtends %>",
"compilerOptions": {
"outDir": "<%= outDir %>-server",
"module": "commonjs",
"types": [
"node"
]
Expand Down
2 changes: 0 additions & 2 deletions packages/schematics/angular/universal/index_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ describe('Universal Schematic', () => {
extends: './tsconfig.app.json',
compilerOptions: {
outDir: './out-tsc/app-server',
module: 'commonjs',
types: ['node'],
},
files: [
Expand All @@ -116,7 +115,6 @@ describe('Universal Schematic', () => {
extends: './tsconfig.app.json',
compilerOptions: {
outDir: '../../out-tsc/app-server',
module: 'commonjs',
types: ['node'],
},
files: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"extends": "./tsconfig.app.json",
"compilerOptions": {
"outDir": "../dist-server",
"module": "commonjs",
"types": []
},
"files": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"compilerOptions": {
"outDir": "../dist-server",
"baseUrl": "./",
"module": "commonjs",
"types": []
},
"files": [
Expand Down

0 comments on commit a2b158b

Please sign in to comment.