From c65b049996a8de9d9fcc66631872424cbe5f13f9 Mon Sep 17 00:00:00 2001
From: Alan Agius <alan.agius4@gmail.com>
Date: Fri, 9 Jul 2021 06:33:20 +0200
Subject: [PATCH] fix(@angular-devkit/build-angular): fail browser build when
 index generation fails

Currently, when there is an error during index generation this is just been logged in the console.
---
 .../build_angular/src/browser/index.ts             | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/packages/angular_devkit/build_angular/src/browser/index.ts b/packages/angular_devkit/build_angular/src/browser/index.ts
index 160dc7ca02af..00fe9a354050 100644
--- a/packages/angular_devkit/build_angular/src/browser/index.ts
+++ b/packages/angular_devkit/build_angular/src/browser/index.ts
@@ -648,6 +648,7 @@ export function buildWebpackBrowser(
                     postTransform: transforms.indexHtml,
                   });
 
+                  let hasErrors = false;
                   for (const [locale, outputPath] of outputPaths.entries()) {
                     try {
                       const { content, warnings, errors } = await indexHtmlGenerator.process({
@@ -663,7 +664,10 @@ export function buildWebpackBrowser(
                       if (warnings.length || errors.length) {
                         spinner.stop();
                         warnings.forEach((m) => context.logger.warn(m));
-                        errors.forEach((m) => context.logger.error(m));
+                        errors.forEach((m) => {
+                          context.logger.error(m);
+                          hasErrors = true;
+                        });
                         spinner.start();
                       }
 
@@ -677,7 +681,13 @@ export function buildWebpackBrowser(
                     }
                   }
 
-                  spinner.succeed('Index html generation complete.');
+                  if (hasErrors) {
+                    spinner.fail('Index html generation failed.');
+
+                    return { success: false };
+                  } else {
+                    spinner.succeed('Index html generation complete.');
+                  }
                 }
 
                 if (options.serviceWorker) {