Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit e3a94cb

Browse files
alan-agius4clydin
authored andcommittedJul 13, 2020
fix(@angular-devkit/build-angular): don't emit empty warnings
Closes #18231 (cherry picked from commit 0b20676)
1 parent 3713787 commit e3a94cb

File tree

1 file changed

+10
-5
lines changed
  • packages/angular_devkit/build_angular/src/angular-cli-files/utilities

1 file changed

+10
-5
lines changed
 

‎packages/angular_devkit/build_angular/src/angular-cli-files/utilities/stats.ts

+10-5
Original file line numberDiff line numberDiff line change
@@ -100,10 +100,11 @@ export function statsWarningsToString(json: any, statsConfig: any) {
100100
}
101101

102102
return rs('\n' + warnings
103-
.map((warning: any) => `${warning}`)
104-
.filter((warning: string) => !ERRONEOUS_WARNINGS.some((erroneous) => erroneous.test(warning)))
105-
.map((warning: string) => y(`WARNING in ${warning}`))
106-
.join('\n\n'));
103+
.filter(m => !!m)
104+
.map((warning: any) => `${warning}`)
105+
.filter((warning: string) => !ERRONEOUS_WARNINGS.some((erroneous) => erroneous.test(warning)))
106+
.map((warning: string) => y(`WARNING in ${warning}`))
107+
.join('\n\n'));
107108
}
108109

109110
export function statsErrorsToString(json: any, statsConfig: any) {
@@ -115,7 +116,11 @@ export function statsErrorsToString(json: any, statsConfig: any) {
115116
errors.push(...json.children.map((c: any) => c.errors));
116117
}
117118

118-
return rs('\n' + errors.map((error: any) => r(`ERROR in ${error}`)).join('\n'));
119+
return rs('\n' + errors
120+
.filter(m => !!m)
121+
.map((error: any) => r(`ERROR in ${error}`))
122+
.join('\n\n')
123+
);
119124
}
120125

121126
export function statsHasErrors(json: any): boolean {

0 commit comments

Comments
 (0)
Please sign in to comment.