Skip to content

Commit

Permalink
fix(@angular-devkit/build-angular): don't emit empty warnings
Browse files Browse the repository at this point in the history
Closes #18231

(cherry picked from commit 0b20676)
  • Loading branch information
alan-agius4 authored and clydin committed Jul 13, 2020
1 parent 3713787 commit e3a94cb
Showing 1 changed file with 10 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,11 @@ export function statsWarningsToString(json: any, statsConfig: any) {
}

return rs('\n' + warnings
.map((warning: any) => `${warning}`)
.filter((warning: string) => !ERRONEOUS_WARNINGS.some((erroneous) => erroneous.test(warning)))
.map((warning: string) => y(`WARNING in ${warning}`))
.join('\n\n'));
.filter(m => !!m)
.map((warning: any) => `${warning}`)
.filter((warning: string) => !ERRONEOUS_WARNINGS.some((erroneous) => erroneous.test(warning)))
.map((warning: string) => y(`WARNING in ${warning}`))
.join('\n\n'));
}

export function statsErrorsToString(json: any, statsConfig: any) {
Expand All @@ -115,7 +116,11 @@ export function statsErrorsToString(json: any, statsConfig: any) {
errors.push(...json.children.map((c: any) => c.errors));
}

return rs('\n' + errors.map((error: any) => r(`ERROR in ${error}`)).join('\n'));
return rs('\n' + errors
.filter(m => !!m)
.map((error: any) => r(`ERROR in ${error}`))
.join('\n\n')
);
}

export function statsHasErrors(json: any): boolean {
Expand Down

0 comments on commit e3a94cb

Please sign in to comment.