From e3e78776782da9d933f7b0e4c6bf391a62585bee Mon Sep 17 00:00:00 2001
From: Charles Lyding <19598772+clydin@users.noreply.github.com>
Date: Mon, 7 Nov 2022 16:23:00 -0500
Subject: [PATCH] fix(@angular-devkit/architect): default to failure if no
 builder result is provided

Currently, if an architect builder does not provide any results, the CLI will crash
trying to access an error message property on the result. Instead architect will now
provide a default failure result `{ success: false }` in the event that the builder
exits prior to generating a result. Thrown errors continue to be propagated as before.

(cherry picked from commit 774e83df8b6c7d854881519c46458f73994f0dc0)
---
 packages/angular_devkit/architect/src/create-builder.ts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/packages/angular_devkit/architect/src/create-builder.ts b/packages/angular_devkit/architect/src/create-builder.ts
index 6aa83bd36cab..8bc03daf1921 100644
--- a/packages/angular_devkit/architect/src/create-builder.ts
+++ b/packages/angular_devkit/architect/src/create-builder.ts
@@ -8,7 +8,7 @@
 
 import { analytics, experimental, json, logging } from '@angular-devkit/core';
 import { Observable, Subscription, from, isObservable, of, throwError } from 'rxjs';
-import { mergeMap, tap } from 'rxjs/operators';
+import { defaultIfEmpty, mergeMap, tap } from 'rxjs/operators';
 import {
   BuilderContext,
   BuilderHandlerFn,
@@ -219,6 +219,7 @@ export function createBuilder<OptT = json.JsonObject, OutT extends BuilderOutput
         subscriptions.push(
           result
             .pipe(
+              defaultIfEmpty({ success: false } as unknown),
               tap(() => {
                 progress({ state: BuilderProgressState.Running, current: total }, context);
                 progress({ state: BuilderProgressState.Stopped }, context);