fix(@schematics/angular): only generate package.json under app in…

… strict applications (cherry picked from commit 1559ad6)
angular · Jun 16, 2020 · f655ba0 · f655ba0
1 parent 117d142
commit f655ba0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/schematics/angular/application/index.ts b/packages/schematics/angular/application/index.ts
@@ -399,6 +399,9 @@ export default function (options: ApplicationOptions): Rule {
       }),
       mergeWith(
         apply(url('./other-files'), [
+          options.strict
+            ? noop()
+            : filter(path => path !== '/package.json.template'),
           componentOptions.inlineTemplate
             ? filter(path => !path.endsWith('.html.template'))
             : noop(),

diff --git a/packages/schematics/angular/application/index_spec.ts b/packages/schematics/angular/application/index_spec.ts
@@ -310,13 +310,12 @@ describe('Application Schematic', () => {
     expect(content.sideEffects).toBe(false);
   });
 
-  it('sideEffects property should be false when not in strict mode', async () => {
+  it('sideEffects package.json should not exist when not in strict mode', async () => {
     const options = { ...defaultOptions, projectRoot: '', strict: false };
 
     const tree = await schematicRunner.runSchematicAsync('application', options, workspaceTree)
       .toPromise();
-    const content = JSON.parse(tree.readContent('/src/app/package.json'));
-    expect(content.sideEffects).toBe(true);
+    expect(tree.exists('/src/app/package.json')).toBeFalse();
   });
 
   describe('custom projectRoot', () => {