Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: angular/angular-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v9.1.1
Choose a base ref
...
head repository: angular/angular-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v9.1.2
Choose a head ref
  • 5 commits
  • 11 files changed
  • 4 contributors

Commits on Apr 10, 2020

  1. Copy the full SHA
    8c71aff View commit details
  2. fix(@ngtools/webpack): give higher priority to ivy-specific entry-points

    When Ivy is enabled in an app, the app's dependencies are processed by
    ngcc (the Angular compatibility compiler), which will generate new
    Ivy-compatible entry-points in each package. To allow webpack find those
    entry-points, it will add references to them in `package.json`, named
    after the original property with the `_ivy_ngcc` suffix. So, for
    example, `es2015` and `module` will become `es2015_ivy_ngcc` and
    `module_ivy_ngcc`.
    
    Previously, the `mainFields` passed to webpack would give higher
    priority to an Ivy entry-point compared to the corresponding non-ivy
    entry-point but not compared to other entry-points. For example,
    `es2015, module` would becode
    `es2015_ivy_ngcc, es2015, module_ivy_ngcc, module`. This could mean that
    `es2015` would be preferred over `module_ivy_ngcc`, even though the
    former is probably not Ivy-ready. Generally, if `es2015` exists and has
    a higher priority than `module`, then `es2015_ivy_ngcc` would be
    generated before (or instead of) `module_ivy_ngcc`, but this can be
    changed using an ngcc configuration file (`ngcc.config.js`).
    
    This commit fixes this by ensuring that any `_ivy_ngcc` entry-point is
    considered before any of the original entry-points in the `mainFields`
    list.
    
    NOTE:
    While it is possible that a format is Ivy-compatible without bhaving an
    `_ivy_ngcc` suffix (e.g. if the user does a manual ngcc pass without
    `--create-ivy-entry-points`), it is quite unlikely to happen and even if
    it does, choosing a different format should be OK.
    
    (cherry picked from commit c7c574a)
    gkalpak authored and dgp1130 committed Apr 10, 2020
    Copy the full SHA
    25ef78e View commit details

Commits on Apr 13, 2020

  1. test: update ng-packagr tests tsconfig as per CLI default

    This seems to be the root cause of the failures in the following PR:
    #17455
    
    (cherry picked from commit a78fe96)
    alan-agius4 authored and dgp1130 committed Apr 13, 2020
    Copy the full SHA
    5023051 View commit details

Commits on Apr 14, 2020

  1. fix(@angular/cli): ensure Node.js message is shown on old Node.js ver…

    …sions
    
    (cherry picked from commit 1f16002)
    clydin authored and dgp1130 committed Apr 14, 2020
    Copy the full SHA
    a069073 View commit details

Commits on Apr 16, 2020

  1. release: v9.1.2

    dgp1130 committed Apr 16, 2020
    Copy the full SHA
    8baede8 View commit details
Loading