Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng new should error on multiple args #12549

Closed
vikerman opened this issue Oct 10, 2018 · 2 comments · Fixed by #13480
Closed

ng new should error on multiple args #12549

vikerman opened this issue Oct 10, 2018 · 2 comments · Fixed by #13480
Labels
area: angular/cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken
Milestone

Comments

@vikerman
Copy link
Contributor

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)

- [x] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

v7.0.0-rc.2

Repro steps

Running ng new with extra args doesn't throw an error. This could happen when user forgets to put --directory

ng new hello test/path/hello

Should display an error. Instead it just creates a new directory hello/ and continues without any errors.

Desired functionality

Display error message about extra args

@alan-agius4 alan-agius4 added freq1: low Only reported by a handful of users who observe it rarely severity3: broken area: angular/cli labels Oct 11, 2018
@ngbot ngbot bot added this to the needsTriage milestone Oct 11, 2018
@alan-agius4
Copy link
Collaborator

alan-agius4 commented Oct 17, 2018

Apparently even invalid arguments are not erroring out example:

ng new my app —foo

hansl pushed a commit that referenced this issue Jan 30, 2019
When an addition argument is parsed the schematic commands should fail with an error.

Fixes #12549
hansl pushed a commit that referenced this issue Jan 30, 2019
When an addition argument is parsed the schematic commands should fail with an error.

Fixes #12549
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: angular/cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants