Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angularMajorCompatGuarantee): add check for range === null fixes #12644 #12806

Closed
wants to merge 1 commit into from

Conversation

tkrugg
Copy link
Contributor

@tkrugg tkrugg commented Oct 30, 2018

  • Is there any better way to handle this check with typescript?
  • I didn't find any tests targeting specifically peer dependencies. Can you point me at it?
  • is there any linter formatter I should ran?

Fixes #12644

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@tkrugg
Copy link
Contributor Author

tkrugg commented Oct 30, 2018

I've signed it

@googlebot
Copy link

CLAs look good, thanks!

@tkrugg tkrugg force-pushed the semver branch 2 times, most recently from e3c780c to f7b164b Compare October 30, 2018 14:09
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly also fix the commit message as per guidelines https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md

fix(@schematics/update): add check for invalid ranges

Fixes #12644

@tkrugg tkrugg force-pushed the semver branch 2 times, most recently from 5782db3 to 3ecef49 Compare November 12, 2018 09:15
@alan-agius4
Copy link
Collaborator

Can you please rebase?

@tkrugg
Copy link
Contributor Author

tkrugg commented Nov 14, 2018

rebased

@tkrugg
Copy link
Contributor Author

tkrugg commented Nov 19, 2018

@alan-agius4 any idea why some of the checks are failing?

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Dec 4, 2018

That is because this method return type should not be of type boolean but rather string.

@mgechev
Copy link
Member

mgechev commented Dec 20, 2018

@tkrugg the build is still failing. Would you fix the typing errors?

@alan-agius4
Copy link
Collaborator

@tkrugg can you check the above comment?

Thank you.

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jan 17, 2019
@mgechev mgechev closed this in 1deb74f Jan 18, 2019
mgechev pushed a commit that referenced this pull request Jan 18, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating Angular CLI & Core: "Cannot read property 'split' of null"
4 participants