Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uses white foreground text without specifying background text color, hard to read on white terminal #13439

Closed
mbward opened this issue Jan 15, 2019 · 5 comments · Fixed by #13443
Labels
area: devkit/core freq1: low Only reported by a handful of users who observe it rarely severity2: inconvenient type: bug/fix
Milestone

Comments

@mbward
Copy link

mbward commented Jan 15, 2019

Bug Report or Feature Request (mark with an x)

- [x] bug report
- [ ] feature request

Versions

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 7.2.1
Node: 10.13.0
OS: linux x64
Angular: 7.2.0
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.12.1
@angular-devkit/build-angular     0.12.1
@angular-devkit/build-optimizer   0.12.1
@angular-devkit/build-webpack     0.12.1
@angular-devkit/core              7.2.1
@angular-devkit/schematics        7.2.1
@angular/cli                      7.2.1
@ngtools/webpack                  7.2.1
@schematics/angular               7.2.1
@schematics/update                0.12.1
rxjs                              6.3.3
typescript                        3.2.2
webpack                           4.23.1

Repro steps

Set terminal emulator to use black font on white background

ng --version

(and various other commands)

The logo is red, and the remaining text is a very light gray.

Desired functionality

I can read the text. It doesn't try to use a "white" font color unless it also sets the background font color.

@mbward
Copy link
Author

mbward commented Jan 15, 2019

I assume these lines are what's causing it.

https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/core/node/cli-logger.ts#L28-L32

Easiest fix would be to have color for default and info levels just be the identity function and not change the color. Or you could always set the background color to black whenever setting the foreground color.

@alan-agius4 alan-agius4 added type: bug/fix freq1: low Only reported by a handful of users who observe it rarely severity2: inconvenient area: devkit/core labels Jan 15, 2019
@ngbot ngbot bot added this to the Backlog milestone Jan 15, 2019
@mbward
Copy link
Author

mbward commented Jan 15, 2019

CC @evmar

@mbward
Copy link
Author

mbward commented Jan 15, 2019

It's not freq1: low, it happens all the time.

Please also add effort1 and any other relevant tags, e.g. accessibility.

@evmar
Copy link

evmar commented Jan 15, 2019

I'm not sure why you CC'd me, but I also would like to see this fixed. :)

mbward pushed a commit to mbward/angular-cli that referenced this issue Jan 15, 2019
Previously, we set the color to white, which is (nearly) invisible on
terminals with a white background.

Fixes angular#13439.
mbward pushed a commit to mbward/angular-cli that referenced this issue Jan 15, 2019
…ault colors

Previously, we set the color to white, which is (nearly) invisible on
terminals with a white background.

Fixes angular#13439.
kyliau pushed a commit that referenced this issue Jan 16, 2019
…ault colors

Previously, we set the color to white, which is (nearly) invisible on
terminals with a white background.

Fixes #13439.
kyliau pushed a commit that referenced this issue Jan 16, 2019
…ault colors

Previously, we set the color to white, which is (nearly) invisible on
terminals with a white background.

Fixes #13439.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: devkit/core freq1: low Only reported by a handful of users who observe it rarely severity2: inconvenient type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants