Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bazel] Update gitignore for bazel-out directory #13636

Closed
lacolaco opened this issue Dec 31, 2018 · 2 comments 路 Fixed by #13637
Closed

[Bazel] Update gitignore for bazel-out directory #13636

lacolaco opened this issue Dec 31, 2018 · 2 comments 路 Fixed by #13637
Assignees
@alexeagle

Comments

@lacolaco
Copy link
Contributor

馃殌 feature request

Relevant Package

  • @angular/bazel

Description

A clear and concise description of the problem or missing capability...

bazel-out directory is created by bazel build but it is not ignored by Git.
It is a compilation output similar to tsc-out.

Describe the solution you'd like

If you have a solution in mind, please describe it.

Update gitignore file for bazel-out directory when ng new --collection=@angular/bazel (or ng add @angular/bazel in the future)
@alexeagle alexeagle self-assigned this Feb 8, 2019
@alexeagle alexeagle transferred this issue from angular/angular Feb 8, 2019
alexeagle added a commit to alexeagle/angular-cli that referenced this issue Feb 8, 2019
@alexeagle
fix(@schematics/angular): Include bazel-out in .gitignore
5880d18 
We could do this only when we know the user has opted into using Bazel, like in the @angular/bazel schematics.
However, the complexity of amending new lines to the .gitignore isn't worth it, when we can just add one line here.

Fixes angular#13636
@alexeagle alexeagle mentioned this issue Feb 8, 2019
Merged
alexeagle added a commit that referenced this issue Feb 9, 2019
@alexeagle
fix(@schematics/angular): Include bazel-out in .gitignore
6fc6e84 
We could do this only when we know the user has opted into using Bazel, like in the @angular/bazel schematics.
However, the complexity of amending new lines to the .gitignore isn't worth it, when we can just add one line here.

Fixes #13636
alexeagle added a commit that referenced this issue Feb 9, 2019
@alexeagle
fix(@schematics/angular): Include bazel-out in .gitignore
62264ce 
We could do this only when we know the user has opted into using Bazel, like in the @angular/bazel schematics.
However, the complexity of amending new lines to the .gitignore isn't worth it, when we can just add one line here.

Fixes #13636
@kyliau
Copy link
Contributor

kyliau commented Feb 13, 2019

Similar fix is also in @angular/bazel: https://github.com/angular/angular/blob/master/packages/bazel/src/schematics/ng-add/index.ts#L85-L103

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexeagle alexeagle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(@schematics/angular): Include bazel-out in .gitignore alexeagle/angular-cli
3 participants
@alexeagle @lacolaco @kyliau