Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 'fix(@schematics/angular): stop offering SASS option for ng new #13444' #13739

Closed
ben-wall opened this issue Feb 22, 2019 · 5 comments · Fixed by #13777
Closed

Revert 'fix(@schematics/angular): stop offering SASS option for ng new #13444' #13739

ben-wall opened this issue Feb 22, 2019 · 5 comments · Fixed by #13777

Comments

@ben-wall
Copy link

I initially thought this was a bug!
ng g c component-name --style=sass generates .scss files
ng new my-project --style=sass generates .scss files
What is the reason behind this change?
What about those of us who prefer using the sass indented syntax? It is still supported and they are not dropping it so I don't see any reason to remove it from ng generate and ng new simply because most developers prefer the scss syntax.
This is really causing a problem for my workflow as I am using let g:angular_cli_stylesheet_format = 'sass' in my .vimrc so I now have to convert everything to scss and start working with syntax I don't like to use.

#13444

@andyg3

@alan-agius4 alan-agius4 added the needs: discussion On the agenda for team meeting to determine next steps label Feb 22, 2019
@alexeagle
Copy link
Contributor

@nex3 can you give Angular team some guidance about whether Indented Sass (.sass files) should be considered "deprecated"? Should we stop creating new Angular projects using the old syntax?

@nex3
Copy link

nex3 commented Feb 26, 2019

As far as the Sass team is concerned, the indented syntax is fully supported.

@alan-agius4 alan-agius4 self-assigned this Feb 26, 2019
@alexeagle
Copy link
Contributor

Thanks @nex3! We'll re-introduce support for generating apps in that syntax

@alan-agius4 alan-agius4 removed the needs: discussion On the agenda for team meeting to determine next steps label Feb 27, 2019
@ngbot ngbot bot added this to the needsTriage milestone Feb 27, 2019
hansl pushed a commit that referenced this issue Mar 4, 2019
…ention

Sass Indented (.sass) is fully supported by the Sass team and we should still offer and support it.

Fixes #13739
@ben-wall
Copy link
Author

ben-wall commented Mar 5, 2019

Somewhat ironically, and after switching to scss because I was forced to, I now prefer it in some cases

vikerman pushed a commit that referenced this issue Mar 11, 2019
…ention

Sass Indented (.sass) is fully supported by the Sass team and we should still offer and support it.

Fixes #13739
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants