Skip to content

Migration from v9 to v10 retains tsconfig module value as esnext #18073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
destus90 opened this issue Jun 30, 2020 · 2 comments · Fixed by #18077
Closed

Migration from v9 to v10 retains tsconfig module value as esnext #18073

destus90 opened this issue Jun 30, 2020 · 2 comments · Fixed by #18077
Assignees
@alan-agius4
Labels
area: @schematics/angular freq3: high type: bug/fix
Milestone
needsTriage

Comments

@destus90
Copy link
Contributor

After the migration to Angualr 10, the value of my tsconfig.base.json module looks like esnext. For a newly created project, I found out that the option is set as es2020 due to #17637. Is it worth setting es2020 for an existing project?
@ngbot ngbot bot modified the milestone: needsTriage Jun 30, 2020
@alan-agius4
Copy link
Collaborator

@destus90, yes.

@alan-agius4 alan-agius4 mentioned this issue Jun 30, 2020
Merged
@alan-agius4 alan-agius4 self-assigned this Jul 1, 2020
filipesilva pushed a commit that referenced this issue Jul 1, 2020
@alan-agius4 @filipesilva
fix(@schematics/angular): migrate tsconfig.base.json module and targe…
7df079a 
…t options

Closes #18073
filipesilva pushed a commit that referenced this issue Jul 1, 2020
@alan-agius4 @filipesilva
fix(@schematics/angular): migrate tsconfig.base.json module and targe…
c9f5304 
…t options

Closes #18073
villelahdenvuo pushed a commit to villelahdenvuo/angular-cli that referenced this issue Jul 6, 2020
@alan-agius4 @villelahdenvuo
fix(@schematics/angular): migrate tsconfig.base.json module and targe…
1edf340 
…t options

Closes angular#18073
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alan-agius4 alan-agius4

Labels
area: @schematics/angular freq3: high type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging a pull request may close this issue.

fix(@schematics/angular): migrate tsconfig.base.json module and targe…
2 participants
@alan-agius4 @destus90