New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESBuild suddenly displays blank page in development mode [17.1.0] #26902
Comments
Update: I downgraded to 17.0.9 and now it works again! In the linked github project, this is the branch called "downgrade" |
What is happening here is that the baseHref is set to This can be seen in the response What are your intentions of having a base-href of |
Thanks @alan-agius4 . |
@alan-agius4 it works! Amazing, thank you so much! You're welcome to close the issue, apparently it allows for the missing slash in 17.0.9, and not in 17.1.0. Cheers, and thank you |
Found this old PR in Vite, where they allowed missing trailing slashes: |
@alan-agius4 before you close it, I noticed that now that I changed the baseHref to include a trailing slash, references to assets like this: /assets/test.gif do not work in development mode, as the link does not get the baseHref added. Anything we can do about this? It would be pretty unfortunate if global references to assets stopped working. If I remove the trailing slash again, links to /assets work again - but of course then the compiler complains once it's time to do a production build. Update: I did some digging and that's apparently by design. baseHref is only prepended to relative urls, not global urls. |
@spock123, that is indeed working as expected. I am not quick sure what setup / structure are you going for but from the gist of it it looks like you'd want to set a base-href of |
@alan-agius4 yes thanks. I think I will do that in development mode. thank you. We could of course replicate the cli configuration targets but it is already quite large due to the amounts of locales (we have 12!) It used to be an option for the cli, to set the base href when using We'll solve it somehow, thanks for your time |
Closing as the issue seems to have been resolved. |
@alan-agius4 It has indeed. Thanks |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Command
serve
Is this a regression?
The previous version in which this bug was not present was
No response
Description
Since yesterday, suddenly all our 4 clients started to only display a blank page when run in development mode. No errors anywhere.
Building and deployment works fine.
When changing the builder back to "browser" everything works again.
I have tried to create a minimal version by stripping away all code, but still maintain the issue, as least in our end.
Minimal Reproduction
Exception or Error
Your Environment
Anything else relevant?
It apparently stopped working since yesterday, where all our clients were functioning without issue.
Multiple developers experience same issue, so it's probably not a local environment issue.
We have reverted to use the old browser builder and it works fine there, - frustratingly.
Appreciate any help
The text was updated successfully, but these errors were encountered: