Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

FormController.$setValidity should be able to reset child validation #13202

Closed
bjoernWahle opened this issue Oct 29, 2015 · 0 comments · Fixed by #16601
Closed

FormController.$setValidity should be able to reset child validation #13202

bjoernWahle opened this issue Oct 29, 2015 · 0 comments · Fixed by #16601
Labels
component: forms frequency: low severity: inconvenient type: feature
Milestone
Ice Box

Comments

@bjoernWahle
Copy link

I implemented a behaviour to add my server-side errors to my client-side angular errors. If I want to reset my form ($setPristine() and $setValidity()), only the general validation state of my form is reset.

My workaround for this was, to call $setValidity() for all fields of the form manually.

I think it would be nice to have method or an argument for $setValidity(), that resets child validation state as well.
@Narretz Narretz added this to the Ice Box milestone Nov 13, 2015
@frederikprijck frederikprijck mentioned this issue May 5, 2017
Closed
@Narretz Narretz mentioned this issue Jun 15, 2018
Merged
3 tasks
Narretz added a commit to Narretz/angular.js that referenced this issue Jun 15, 2018
@Narretz
feat(form.FormController): add $getControls()
30db7f5 
Fixes angular#14749
Closes angular#14517
Closes angular#13202
Narretz added a commit that referenced this issue Jun 18, 2018
@Narretz
feat(form.FormController): add $getControls()

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
5b11145 
Closes #16601
Fixes #14749
Closes #14517
Closes #13202
Narretz added a commit that referenced this issue Jun 18, 2018
@Narretz
feat(form.FormController): add $getControls()

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
c9d1e69 
Closes #16601
Fixes #14749
Closes #14517
Closes #13202
@dependencies dependencies bot mentioned this issue Aug 9, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: forms frequency: low severity: inconvenient type: feature
Projects
None yet
Milestone
Ice Box
Development

Successfully merging a pull request may close this issue.

feat(form.FormController): add $getControls() Narretz/angular.js
2 participants
@Narretz @bjoernWahle