This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(input[number]): validate min/max against viewValue #16325
Merged
+102
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
approved these changes
Nov 13, 2017
test/ng/directive/inputSpec.js
Outdated
| return value + 5; | ||
| }); | ||
|
|
||
| helper.changeInputValueTo('9'); |
There was a problem hiding this comment.
Why not 10 (for symmetry with min)? 😢
test/ng/directive/inputSpec.js
Outdated
| @@ -2465,6 +2465,21 @@ describe('input', function() { | |||
| expect($rootScope.form.alias.$error.min).toBeFalsy(); | |||
| }); | |||
|
|
|||
|
|
|||
| it('should validate against the viewValue', function() { | |||
| var inputElm = helper.compileInput('<input type="number" num-parse ng-model="value" name="alias" min="10" />'); | |||
There was a problem hiding this comment.
num-parse doesn't appear to be used anywhere
| helper.changeInputValueTo('10'); | ||
| expect(inputElm).toBeValid(); | ||
| expect($rootScope.value).toBe(5); | ||
| expect($rootScope.form.alias.$error.min).toBeFalsy(); |
There was a problem hiding this comment.
Should we also have tests that check that we do get an error if the viewValue is bad but the modelValue is good?
petebacondarwin
suggested changes
Nov 14, 2017
This brings the validation in line with HTML5 validation, i.e. what the user has entered is validated, and not a possibly transformed value. Fixes angular#12761 BREAKING CHANGE `input[type=number]` with `ngModel` now validates the input for `max`/`min` against the `ngModelController.$viewValue` instead of the against the `ngModelController.$modelValue`. This affects apps that use `$parsers` or `$formatters` to transform the input / model value. IF you rely on the $modelValue validation, you can overwrite the `min`/`max` validator, as in the following example directive defintion object: ``` { restrict: 'A', require: 'ngModel', link: function(scope, element, attrs, ctrl) { var minValidator = ctrl.$validators.max; ctrk.$validators.max = function(modelValue, viewValue) { return minValidator(modelValue, modelValue); }; } } ```
Narretz
force-pushed
the
fix-number-validation
branch
from
0a3ddfc to
74d96b9
Compare
|
Updated with your suggestions! |
petebacondarwin
approved these changes
Nov 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the validation in line with HTML5 validation and all other
validators.
Fixes #12761
BREAKING CHANGE
....
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix / normalization
What is the current behavior? (You can also link to an open issue here)
See #12761
What is the new behavior (if this is a feature change)?
validation of min / max against viewValue
Does this PR introduce a breaking change?
Yes
Please check if the PR fulfills these requirements
Other information:
I believe the BC is moderate enough to be included in 1.7
To switch the validation to the modelValue, it's as easy as adding this into a directive:
I could even publish this is as a configurable third party directive that allows you to do this for any validator.