IPv6 address returned from $location.host() does not include the brackets in IE/Edge

[kelvinau]

I'm submitting a ...

• bug report
• feature request
• other

Current behavior:

For example, when the URL is https://[fd12:3456:789a:74::27], $location.host() returns fd12:3456:789a:74::27 in IE/Edge.

This is because host and hostname of a tag element returns the address without bracket, when we use urlParsingNode, and we use it in urlResolve directly:

angular.js/src/ng/urlUtils.js

Lines 75 to 86 in eb0ccc6

	return {
	href: urlParsingNode.href,
	protocol: urlParsingNode.protocol ? urlParsingNode.protocol.replace(/:$/, '') : '',
	host: urlParsingNode.host,
	search: urlParsingNode.search ? urlParsingNode.search.replace(/^\?/, '') : '',
	hash: urlParsingNode.hash ? urlParsingNode.hash.replace(/^#/, '') : '',
	hostname: urlParsingNode.hostname,
	port: urlParsingNode.port,
	pathname: (urlParsingNode.pathname.charAt(0) === '/')
	? urlParsingNode.pathname
	: '/' + urlParsingNode.pathname
	};

Expected / new behavior:

$location.host() should return the IPv6 address with the brackets. i.e. [fd12:3456:789a:74::27]

Minimal reproduction of the problem with instructions:

Call $location.host() at a IPv6 address using IE/Edge

AngularJS version: 1.7.4

Browser: [ Edge 42.17134.1.0 | IE 11.228.17134.0 ]

Anything else:

I suggest that we can check if the address is in IPv6 format, and add brackets to it if it doesn't exist. Not necessary to check if it's IE/Edge.

[mgol]

Thanks for the report, I confirm the issue. This is an IE/Edge bug, EdgeHTML 17 still has it but it's fixed in the Edge preview (future 18), see https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/16476907/

[mgol]

PR: #16715

[kelvinau]

great!