/
missing_injectable_migration.ts
192 lines (170 loc) Β· 6.55 KB
/
missing_injectable_migration.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
/**
* @license
* Copyright Google Inc. All Rights Reserved.
*
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.io/license
*/
import * as ts from 'typescript';
import {forwardRefResolver} from '../../../src/ngtsc/annotations';
import {Reference} from '../../../src/ngtsc/imports';
import {ResolvedValue, ResolvedValueMap} from '../../../src/ngtsc/partial_evaluator';
import {ClassDeclaration, Decorator} from '../../../src/ngtsc/reflection';
import {Migration, MigrationHost} from './migration';
import {createInjectableDecorator, isClassDeclaration} from './utils';
/**
* Ensures that classes that are provided as an Angular service in either `NgModule.providers` or
* `Directive.providers`/`Component.viewProviders` are decorated with one of the `@Injectable`,
* `@Directive`, `@Component` or `@Pipe` decorators, adding an `@Injectable()` decorator when none
* are present.
*
* At least one decorator is now mandatory, as otherwise the compiler would not compile an
* injectable definition for the service. This is unlike View Engine, where having just an unrelated
* decorator may have been sufficient for the service to become injectable.
*
* In essence, this migration operates on classes that are themselves an NgModule, Directive or
* Component. Their metadata is statically evaluated so that their "providers"/"viewProviders"
* properties can be analyzed. For any provider that refers to an undecorated class, the class will
* be migrated to have an `@Injectable()` decorator.
*
* This implementation mirrors the "missing-injectable" schematic.
*/
export class MissingInjectableMigration implements Migration {
apply(clazz: ClassDeclaration, host: MigrationHost): ts.Diagnostic|null {
const decorators = host.reflectionHost.getDecoratorsOfDeclaration(clazz);
if (decorators === null) {
return null;
}
for (const decorator of decorators) {
const name = getAngularCoreDecoratorName(decorator);
if (name === 'NgModule') {
migrateNgModuleProviders(decorator, host);
} else if (name === 'Directive') {
migrateDirectiveProviders(decorator, host, /* isComponent */ false);
} else if (name === 'Component') {
migrateDirectiveProviders(decorator, host, /* isComponent */ true);
}
}
return null;
}
}
/**
* Iterates through all `NgModule.providers` and adds the `@Injectable()` decorator to any provider
* that is not otherwise decorated.
*/
function migrateNgModuleProviders(decorator: Decorator, host: MigrationHost): void {
if (decorator.args === null || decorator.args.length !== 1) {
return;
}
const metadata = host.evaluator.evaluate(decorator.args[0], forwardRefResolver);
if (!(metadata instanceof Map)) {
return;
}
migrateProviders(metadata, 'providers', host);
// TODO(alxhub): we should probably also check for `ModuleWithProviders` here.
}
/**
* Iterates through all `Directive.providers` and if `isComponent` is set to true also
* `Component.viewProviders` and adds the `@Injectable()` decorator to any provider that is not
* otherwise decorated.
*/
function migrateDirectiveProviders(
decorator: Decorator, host: MigrationHost, isComponent: boolean): void {
if (decorator.args === null || decorator.args.length !== 1) {
return;
}
const metadata = host.evaluator.evaluate(decorator.args[0], forwardRefResolver);
if (!(metadata instanceof Map)) {
return;
}
migrateProviders(metadata, 'providers', host);
if (isComponent) {
migrateProviders(metadata, 'viewProviders', host);
}
}
/**
* Given an object with decorator metadata, iterates through the list of providers to add
* `@Injectable()` to any provider that is not otherwise decorated.
*/
function migrateProviders(metadata: ResolvedValueMap, field: string, host: MigrationHost): void {
if (!metadata.has(field)) {
return;
}
const providers = metadata.get(field) !;
if (!Array.isArray(providers)) {
return;
}
for (const provider of providers) {
migrateProvider(provider, host);
}
}
/**
* Analyzes a single provider entry and determines the class that is required to have an
* `@Injectable()` decorator.
*/
function migrateProvider(provider: ResolvedValue, host: MigrationHost): void {
if (provider instanceof Map) {
if (!provider.has('provide') || provider.has('useValue') || provider.has('useFactory') ||
provider.has('useExisting')) {
return;
}
if (provider.has('useClass')) {
// {provide: ..., useClass: SomeClass, deps: [...]} does not require a decorator on SomeClass,
// as the provider itself configures 'deps'. Only if 'deps' is missing will this require a
// factory to exist on SomeClass.
if (!provider.has('deps')) {
migrateProviderClass(provider.get('useClass') !, host);
}
} else {
migrateProviderClass(provider.get('provide') !, host);
}
} else if (Array.isArray(provider)) {
for (const v of provider) {
migrateProvider(v, host);
}
} else {
migrateProviderClass(provider, host);
}
}
/**
* Given a provider class, adds the `@Injectable()` decorator if no other relevant Angular decorator
* is present on the class.
*/
function migrateProviderClass(provider: ResolvedValue, host: MigrationHost): void {
// Providers that do not refer to a class cannot be migrated.
if (!(provider instanceof Reference)) {
return;
}
const clazz = provider.node as ts.Declaration;
if (isClassDeclaration(clazz) && host.isInScope(clazz) && needsInjectableDecorator(clazz, host)) {
host.injectSyntheticDecorator(clazz, createInjectableDecorator(clazz));
}
}
const NO_MIGRATE_DECORATORS = new Set(['Injectable', 'Directive', 'Component', 'Pipe']);
/**
* Determines if the given class needs to be decorated with `@Injectable()` based on whether it
* already has an Angular decorator applied.
*/
function needsInjectableDecorator(clazz: ClassDeclaration, host: MigrationHost): boolean {
const decorators = host.getAllDecorators(clazz);
if (decorators === null) {
return true;
}
for (const decorator of decorators) {
const name = getAngularCoreDecoratorName(decorator);
if (name !== null && NO_MIGRATE_DECORATORS.has(name)) {
return false;
}
}
return true;
}
/**
* Determines the original name of a decorator if it is from '@angular/core'. For other decorators,
* null is returned.
*/
export function getAngularCoreDecoratorName(decorator: Decorator): string|null {
if (decorator.import === null || decorator.import.from !== '@angular/core') {
return null;
}
return decorator.import.name;
}