Skip to content

Commit

Permalink
fix(compiler-cli): ngcc - remove outdated link (#40285)
Browse files Browse the repository at this point in the history
The link to the "speeding-up-ngcc-compilation" URL does not exist,
it was removed shortly after it was added, but the link in the ngcc
error message was not updated.

Fixes #39837

PR Close #40285
  • Loading branch information
petebacondarwin authored and josephperrott committed Jan 6, 2021
1 parent f6c9133 commit 0b00d65
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions packages/compiler-cli/ngcc/src/locking/sync_locker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ export class SyncLocker {
const pid = this.lockFile.read();
throw new Error(
`ngcc is already running at process with id ${pid}.\n` +
`If you are running multiple builds in parallel then you should pre-process your node_modules via the command line ngcc tool before starting the builds;\n` +
`See https://v9.angular.io/guide/ivy#speeding-up-ngcc-compilation.\n` +
`If you are running multiple builds in parallel then you might try pre-processing your node_modules via the command line ngcc tool before starting the builds.\n` +
`(If you are sure no ngcc process is running then you should delete the lock-file at ${
this.lockFile.path}.)`);
}
Expand Down
3 changes: 1 addition & 2 deletions packages/compiler-cli/ngcc/test/locking/sync_locker_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,7 @@ runInEachFileSystem(() => {
expect(() => locker.lock(() => {}))
.toThrowError(
`ngcc is already running at process with id 188.\n` +
`If you are running multiple builds in parallel then you should pre-process your node_modules via the command line ngcc tool before starting the builds;\n` +
`See https://v9.angular.io/guide/ivy#speeding-up-ngcc-compilation.\n` +
`If you are running multiple builds in parallel then you might try pre-processing your node_modules via the command line ngcc tool before starting the builds.\n` +
`(If you are sure no ngcc process is running then you should delete the lock-file at ${
lockFile.path}.)`);
});
Expand Down

0 comments on commit 0b00d65

Please sign in to comment.