From 0dad375de77f56991a65ace9a9aad70fa814b29f Mon Sep 17 00:00:00 2001 From: Vahid Mohammadi Date: Wed, 5 May 2021 11:44:18 +0430 Subject: [PATCH] fix(common): initialize currencyCode in currencyPipe (#40505) currencyCode should be initialized with the injected default currency code PR Close #40505 --- packages/common/src/pipes/number_pipe.ts | 2 +- packages/common/test/pipes/number_pipe_spec.ts | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/common/src/pipes/number_pipe.ts b/packages/common/src/pipes/number_pipe.ts index fa25ff6017636..087b176b232bd 100644 --- a/packages/common/src/pipes/number_pipe.ts +++ b/packages/common/src/pipes/number_pipe.ts @@ -253,7 +253,7 @@ export class CurrencyPipe implements PipeTransform { display?: 'code'|'symbol'|'symbol-narrow'|string|boolean, digitsInfo?: string, locale?: string): string|null; transform( - value: number|string|null|undefined, currencyCode?: string, + value: number|string|null|undefined, currencyCode: string = this._defaultCurrencyCode, display: 'code'|'symbol'|'symbol-narrow'|string|boolean = 'symbol', digitsInfo?: string, locale?: string): string|null { if (!isValue(value)) return null; diff --git a/packages/common/test/pipes/number_pipe_spec.ts b/packages/common/test/pipes/number_pipe_spec.ts index fcef65caef8d8..ce025f5579b68 100644 --- a/packages/common/test/pipes/number_pipe_spec.ts +++ b/packages/common/test/pipes/number_pipe_spec.ts @@ -140,6 +140,11 @@ import {ɵregisterLocaleData, ɵunregisterLocaleData} from '@angular/core'; expect(pipe.transform(5.1234, 'DKK', '', '', 'da')).toEqual('5,12'); }); + it('should use the injected default currency code if none is provided', () => { + const clpPipe = new CurrencyPipe('en-US', 'CLP'); + expect(clpPipe.transform(1234)).toEqual('CLP1,234'); + }); + it('should support any currency code name', () => { // currency code is unknown, default formatting options will be used expect(pipe.transform(5.1234, 'unexisting_ISO_code', 'symbol'))