-
Notifications
You must be signed in to change notification settings - Fork 24.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(language-service): shorthand syntax with variables (#40239)
This commit fixes an issue in the ivy native language service that caused the logic that finds a target node given a template position to throw away the results. This happened because the source span of a variable node in the shorthand structural directive syntax (i.e. `*ngIf=`) included the entire binding. The result was that we would add the variable node to the path and then later detect that the cursor was outside the key and value spans and throw away the whole result. In general, we do this because we do not want to show information when the cursor is between a key/value (`inputA=¦"123"`). However, when using the shorthand syntax, we run into the situation where we can match an `AttributeBinding` as well as the vaariable in `*ngIf="som¦eValue as myLocalVar"`. This commit updates the visitor to retain enough information in the visit path to throw away invalid targets but keep valid ones if there were multiple results on a `t.Element` or `t.Template`. PR Close #40239
- Loading branch information
1 parent
382f906
commit 12cb39c
Showing
3 changed files
with
53 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters