From 91e92b4e53df8b0182b542bd9de7b720c3465139 Mon Sep 17 00:00:00 2001 From: Pete Bacon Darwin Date: Mon, 31 Aug 2020 17:40:08 +0100 Subject: [PATCH] fixup! fix(compiler-cli): compute source-mappings for localized strings --- packages/compiler-cli/src/ngtsc/translator/src/translator.ts | 3 --- packages/compiler-cli/test/ngtsc/template_mapping_spec.ts | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/compiler-cli/src/ngtsc/translator/src/translator.ts b/packages/compiler-cli/src/ngtsc/translator/src/translator.ts index e0a43348bfae85..6a24078d3b1866 100644 --- a/packages/compiler-cli/src/ngtsc/translator/src/translator.ts +++ b/packages/compiler-cli/src/ngtsc/translator/src/translator.ts @@ -447,11 +447,8 @@ class ExpressionTranslatorVisitor implements ExpressionVisitor, StatementVisitor this.setSourceMapRange(resolvedExpression, ast.getPlaceholderSourceSpan(i - 1)); const templatePart = ast.serializeI18nTemplatePart(i); const templateMiddle = createTemplateMiddle(templatePart.cooked, templatePart.raw); - - // this.setSourceMapRange(resolvedExpression, ast.getMessagePartSourceSpan(i)); this.setSourceMapRange(templateMiddle, ast.getMessagePartSourceSpan(i)); const templateSpan = ts.createTemplateSpan(resolvedExpression, templateMiddle); - // this.setSourceMapRange(templateSpan, ast.getMessagePartSourceSpan(i)); spans.push(templateSpan); } // Create the tail part diff --git a/packages/compiler-cli/test/ngtsc/template_mapping_spec.ts b/packages/compiler-cli/test/ngtsc/template_mapping_spec.ts index 51611dfc75f5e3..b93026c79e6b0e 100644 --- a/packages/compiler-cli/test/ngtsc/template_mapping_spec.ts +++ b/packages/compiler-cli/test/ngtsc/template_mapping_spec.ts @@ -24,7 +24,7 @@ runInEachFileSystem((os) => { beforeEach(() => { env = NgtscTestEnvironment.setup(testFiles); - env.tsconfig({sourceMap: true, target: 'ES2015', enableI18nLegacyMessageIdFormat: false}); + env.tsconfig({sourceMap: true, target: 'es2015', enableI18nLegacyMessageIdFormat: false}); }); describe('Inline templates', () => {