From c7b1cc0f3cf234436cdec9542c6198c1d6183b4d Mon Sep 17 00:00:00 2001 From: Matthieu Riegler Date: Thu, 10 Nov 2022 14:28:21 +0100 Subject: [PATCH] fix(devtools): prevent devTools to load when not text/html document (#48021) On Firefox, Angular DevTools was breaking the XML display because of the script injected Based on contentType, we won't inject that script anymore Fixes #48017 PR Close #48021 --- devtools/projects/shell-browser/src/app/ng-validate.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/devtools/projects/shell-browser/src/app/ng-validate.ts b/devtools/projects/shell-browser/src/app/ng-validate.ts index d7de037380656..6d41ba06c4bc7 100644 --- a/devtools/projects/shell-browser/src/app/ng-validate.ts +++ b/devtools/projects/shell-browser/src/app/ng-validate.ts @@ -14,7 +14,9 @@ window.addEventListener('message', (event: MessageEvent) => { } }); -const script = document.createElement('script'); -script.src = chrome.runtime.getURL('app/detect_angular_for_extension_icon_bundle.js'); -document.documentElement.appendChild(script); -document.documentElement.removeChild(script); +if (document.contentType === 'text/html') { + const script = document.createElement('script'); + script.src = chrome.runtime.getURL('app/detect_angular_for_extension_icon_bundle.js'); + document.documentElement.appendChild(script); + document.documentElement.removeChild(script); +}