Skip to content

Commit

Permalink
fix(compiler-cli): remove unused CLI private exports (#33242)
Browse files Browse the repository at this point in the history
These exports are no longer used by the CLI since 7.1.0.  Since major versions of the CLI are now locked to major versions of the framework, a CLI user will not be able to use FW 9.0+ on an outdated version (<7.1.0) of the CLI that uses these old APIs.

PR Close #33242
  • Loading branch information
clydin authored and atscott committed Nov 1, 2019
1 parent feb5f27 commit fc8eeca
Show file tree
Hide file tree
Showing 8 changed files with 2 additions and 417 deletions.
4 changes: 1 addition & 3 deletions packages/compiler-cli/index.ts
Expand Up @@ -21,10 +21,8 @@ export * from './src/transformers/entry_points';
export * from './src/perform_compile';
export * from './src/tooling';

// TODO(tbosch): remove this once cli 1.5 is fully released,
// and usages in G3 are changed to `CompilerOptions`.
// TODO(tbosch): remove this once usages in G3 are changed to `CompilerOptions`
export {CompilerOptions as AngularCompilerOptions} from './src/transformers/api';
export {NgTools_InternalApi_NG_2 as __NGTOOLS_PRIVATE_API_2} from './src/ngtools_api';

export {ngToTsDiagnostic} from './src/transformers/util';
export {NgTscPlugin} from './src/ngtsc/tsc_plugin';
Expand Down
8 changes: 0 additions & 8 deletions packages/compiler-cli/ngtools2.ts

This file was deleted.

133 changes: 0 additions & 133 deletions packages/compiler-cli/src/ngtools_api.ts

This file was deleted.

149 changes: 0 additions & 149 deletions packages/compiler-cli/src/ngtools_api2.ts

This file was deleted.

30 changes: 0 additions & 30 deletions packages/compiler-cli/test/BUILD.bazel
Expand Up @@ -98,36 +98,6 @@ jasmine_node_test(
],
)

# ngctools_api_spec
ts_library(
name = "ngtools_api_lib",
testonly = True,
srcs = [
"ngtools_api_spec.ts",
],
deps = [
":test_utils",
"//packages/compiler",
"//packages/compiler-cli",
"//packages/private/testing",
"@npm//typescript",
],
)

jasmine_node_test(
name = "ngtools_api",
bootstrap = ["angular/tools/testing/init_node_spec.js"],
data = [
"//packages/core:npm_package",
"//packages/router:npm_package",
],
deps = [
":ngtools_api_lib",
"//packages/core",
"//tools/testing:node",
],
)

# perform_watch_spec
ts_library(
name = "perform_watch_lib",
Expand Down

0 comments on commit fc8eeca

Please sign in to comment.