-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IterableDiffers.extend is not AOT compatible #18554
Labels
area: core
Issues related to the framework runtime
core: differs
freq2: medium
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
type: bug/fix
Milestone
Comments
trotyl
added a commit
to trotyl/angular
that referenced
this issue
Jul 21, 2018
trotyl
added a commit
to trotyl/angular
that referenced
this issue
Jul 21, 2018
trotyl
added a commit
to trotyl/angular
that referenced
this issue
Jul 21, 2018
3 tasks
trotyl
added a commit
to trotyl/angular
that referenced
this issue
Jul 21, 2018
jelbourn
added
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
and removed
severity3: broken
labels
Oct 1, 2020
mhevery
added a commit
to mhevery/angular
that referenced
this issue
Dec 4, 2020
Differs tries to inject parent differ in order to support extending. This does not work in the 'root' injector as the provider overrides the default injector. The fix is to just assume standard set of providers and extend those instead. PR Close angular#25015 Issue Close #111309 `Can't extend IterableDiffers` Issue close angular#18554 `IterableDiffers.extend is not AOT compatible` This is fixed because we no longer have an arrow function in the factory but a proper function which can be imported.
14 tasks
mhevery
added a commit
to mhevery/angular
that referenced
this issue
Dec 4, 2020
Differs tries to inject parent differ in order to support extending. This does not work in the 'root' injector as the provider overrides the default injector. The fix is to just assume standard set of providers and extend those instead. PR Close angular#25015 Issue close angular#11309 `Can't extend IterableDiffers` Issue close angular#18554 `IterableDiffers.extend is not AOT compatible` This is fixed because we no longer have an arrow function in the factory but a proper function which can be imported.
mhevery
added a commit
to mhevery/angular
that referenced
this issue
Dec 5, 2020
Differs tries to inject parent differ in order to support extending. This does not work in the 'root' injector as the provider overrides the default injector. The fix is to just assume standard set of providers and extend those instead. PR Close angular#25015 Issue close angular#11309 `Can't extend IterableDiffers` Issue close angular#18554 `IterableDiffers.extend is not AOT compatible` This is fixed because we no longer have an arrow function in the factory but a proper function which can be imported.
mhevery
added a commit
to mhevery/angular
that referenced
this issue
Dec 5, 2020
Differs tries to inject parent differ in order to support extending. This does not work in the 'root' injector as the provider overrides the default injector. The fix is to just assume standard set of providers and extend those instead. PR close angular#25015 Issue close angular#11309 `Can't extend IterableDiffers` Issue close angular#18554 `IterableDiffers.extend is not AOT compatible` (This is fixed because we no longer have an arrow function in the factory but a proper function which can be imported.)
mhevery
added a commit
to mhevery/angular
that referenced
this issue
Dec 5, 2020
Differs tries to inject parent differ in order to support extending. This does not work in the 'root' injector as the provider overrides the default injector. The fix is to just assume standard set of providers and extend those instead. PR close angular#25015 Issue close angular#11309 `Can't extend IterableDiffers` Issue close angular#18554 `IterableDiffers.extend is not AOT compatible` (This is fixed because we no longer have an arrow function in the factory but a proper function which can be imported.)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: core
Issues related to the framework runtime
core: differs
freq2: medium
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
type: bug/fix
I'm submitting a...
Current behavior
In IterableDiffers.extend API, it's using a static function call in
providers
list.When using this, it would cause error in AOT compilation:
Expected behavior
There should be no error in AOT.
Possible solutions:
Component.providers
, since it's already (partially) supported inNgModule.imports
;IterableDiffers.extend
API and making it return a newIterableDiffers
instead ofProvider
, would be a breaking change in stable API.Minimal reproduction of the problem with instructions
$(npm bin)/ngc -p src/tsconfig.app.json
.What is the motivation / use case for changing the behavior?
All Angular APIs should be AOT compatible.
Related to #11309 .
Also applies to
KeyValueDiffers
.Environment
The text was updated successfully, but these errors were encountered: