-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compiler): allow trailing comma in array literal #22277
Conversation
please change fix for feat |
8a8a6aa
to
c5f26a2
Compare
cl/186104666 |
Anything holding this up? |
Hi @trotyl! This PR has merge conflicts due to recent upstream merges. |
Allows `[1, 2, ]` syntax in angular expressions. closes angular#20773
c5f26a2
to
a735d3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: global-approvers
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
closes #20773
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #20773
What is the new behavior?
Trailing comma is allowed in
Array
literal since ES5, it's now supported in Angular as well.Does this PR introduce a breaking change?
Other information