-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(router): always stringify matrix parameters #25095
Conversation
7a62d1c
to
e8a4174
Compare
merge assistance: pullapprove seems to be stuck. Also, this can be merged after the 11.1 release today. |
Fix a case where matrix parameters weren't stringified when they are passed as a first command when creating a url tree. Fix return type in parseMatrixParams method because it always returns {[key: string]: string} Closes angular#23165
e8a4174
to
a91bdde
Compare
FYI, just did a rebase to rerun CI with the most up-to-date version of the codebase, PullApprove got updated as well. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fix a case where matrix parameters weren't stringified when they are passed as a first command
when creating a url tree. Fix return type in parseMatrixParams method
because it always returns {[key: string]: string}
Closes #23165
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Matrix parameters are not stringified when then they are passed as the first command.
Issue Number: #23165
What is the new behavior?
Matrix parameters are always stringified
Does this PR introduce a breaking change?
Other information