Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): always stringify matrix parameters #25095

Closed
wants to merge 1 commit into from

Conversation

AlexMokin
Copy link
Contributor

@AlexMokin AlexMokin commented Jul 25, 2018

Fix a case where matrix parameters weren't stringified when they are passed as a first command
when creating a url tree. Fix return type in parseMatrixParams method
because it always returns {[key: string]: string}

Closes #23165

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Matrix parameters are not stringified when then they are passed as the first command.

Issue Number: #23165

What is the new behavior?

Matrix parameters are always stringified

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ngbot ngbot bot added this to the needsTriage milestone Jan 24, 2019
@atscott atscott added the target: patch This PR is targeted for the next patch release label Jan 19, 2021
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jan 19, 2021
@pullapprove pullapprove bot requested a review from atscott January 19, 2021 20:11
@atscott
Copy link
Contributor

atscott commented Jan 19, 2021

presubmit
global presubmit

@atscott atscott added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jan 20, 2021
@atscott
Copy link
Contributor

atscott commented Jan 20, 2021

merge assistance: pullapprove seems to be stuck. Also, this can be merged after the 11.1 release today.

Fix a case where matrix parameters weren't stringified when they are passed as a first command
when creating a url tree. Fix return type in parseMatrixParams method
because it always returns {[key: string]: string}

Closes angular#23165
@AndrewKushnir AndrewKushnir removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jan 20, 2021
@AndrewKushnir
Copy link
Contributor

FYI, just did a rebase to rerun CI with the most up-to-date version of the codebase, PullApprove got updated as well.

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Jan 21, 2021
jessicajaniuk pushed a commit that referenced this pull request Jan 21, 2021
Fix a case where matrix parameters weren't stringified when they are passed as a first command
when creating a url tree. Fix return type in parseMatrixParams method
because it always returns {[key: string]: string}

Closes #23165

PR Close #25095
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: router cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParamMap returns a number if number used in navigate
6 participants