fix(service-worker): detect new version even if files are identical to an old one #26006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added
type: bug/fix
action: review
|
You can preview d12a118 at https://pr26006-d12a118.ngbuilds.io/. |
gkalpak
force-pushed
the
fix-sw-detect-rollback-as-new-version
branch
from
d12a118
to
ca19ce5
Compare
|
You can preview ca19ce5 at https://pr26006-ca19ce5.ngbuilds.io/. |
|
You can preview 79fa1bc at https://pr26006-79fa1bc.ngbuilds.io/. |
gkalpak
force-pushed
the
fix-sw-detect-rollback-as-new-version
branch
from
79fa1bc
to
94ad278
Compare
|
You can preview 94ad278 at https://pr26006-94ad278.ngbuilds.io/. |
IgorMinar
approved these changes
Mar 5, 2019
IgorMinar
added
action: merge
|
@gkalpak can you please rebase this to get rid of the pending pullapprove status? thanks |
…o an old one Previously, if an app version contained the same files as an older version (e.g. making a change, then rolling it back), the SW would not detect it as the latest version (and update clients). This commit fixes it by adding a `timestamp` field in `ngsw.json`, which makes each build unique (with sufficiently high probability). Fixes angular#24338
…tical to an old one
gkalpak
force-pushed
the
fix-sw-detect-rollback-as-new-version
branch
from
94ad278
to
b158057
Compare
AndrewKushnir
pushed a commit
that referenced
this pull request
Mar 5, 2019
…o an old one (#26006) Previously, if an app version contained the same files as an older version (e.g. making a change, then rolling it back), the SW would not detect it as the latest version (and update clients). This commit fixes it by adding a `timestamp` field in `ngsw.json`, which makes each build unique (with sufficiently high probability). Fixes #24338 PR Close #26006
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Docs have been added / updated (for bug fixes / features)PR Type
What is the current behavior?
If an app version (aka manifest) contains the same files as an older version (e.g. making a change, then rolling it back), the SW would not detect it as the latest version (and update clients).
Issue Number: #24338
What is the new behavior?
A new
timestampfield is added inngsw.json(based on the current date), which makes each build unique (with sufficiently high probability).Does this PR introduce a breaking change?
Other information
Fixes #24338.