Skip to content

fix(bazel): protractor utils cannot start server on windows #27915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(bazel): protractor utils cannot start server on windows #27915

wants to merge 1 commit into from
+91 −15

Conversation

devversion
Copy link
Member

  • Currently the protractor utils assume that the specified Bazel server runfile can be resolved by just using the real file system. This is not the case on Windows because the runfiles are not symlinked into the working directory and need to be resolved through the runfile manifest.

@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: bazel Issues related to the published `@angular/bazel` build rules labels Jan 3, 2019
@devversion devversion requested a review from gregmagolan January 3, 2019 19:29
@ngbot ngbot bot added this to the needsTriage milestone Jan 3, 2019
@devversion devversion added the hotlist: components team Related to Angular CDK or Angular Material label Jan 3, 2019
@devversion devversion requested a review from alexeagle January 3, 2019 19:29
@mary-poppins

This comment has been minimized.

Sign in to view
@mary-poppins

This comment has been minimized.

Sign in to view
@devversion devversion force-pushed the fix/bazel-protractor-utils-windows-server branch from 0dc1788 to c627eea Compare January 3, 2019 20:14
@mary-poppins

This comment has been minimized.

Sign in to view
@mary-poppins
Copy link

You can preview 8344b50 at https://pr27915-8344b50.ngbuilds.io/.

@AndrewKushnir
Copy link
Contributor

@devversion could you please rebase from the latest master? There was a problem with one test (causing test_ivy_aot to fail) that was resolved in this commit. Thank you.

@devversion devversion force-pushed the fix/bazel-protractor-utils-windows-server branch from 8344b50 to 9db97fb Compare January 4, 2019 18:31
@devversion
Copy link
Member Author

@AndrewKushnir Rebased. Thanks for the heads up.

@mary-poppins
Copy link

You can preview 9db97fb at https://pr27915-9db97fb.ngbuilds.io/.

@devversion
fix(bazel): protractor utils cannot start server on windows
cb7eb6a 
* Currently the protractor utils assume that the specified Bazel server runfile can be resolved by just using the real file system. This is not the case on Windows because the runfiles are not symlinked into the working directory and need to be resolved through the runfile manifest.
@devversion devversion force-pushed the fix/bazel-protractor-utils-windows-server branch from 9db97fb to cb7eb6a Compare January 7, 2019 11:28
@devversion devversion requested a review from a team as a code owner January 7, 2019 11:28
@mary-poppins
Copy link

You can preview cb7eb6a at https://pr27915-cb7eb6a.ngbuilds.io/.

@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 7, 2019
@alexeagle
Copy link
Contributor

caretaker: pullapprove not marking this green, though it has required reviews

@alexeagle alexeagle removed the request for review from gregmagolan January 7, 2019 21:18
@alexeagle alexeagle removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jan 7, 2019
kara pushed a commit that referenced this pull request Jan 7, 2019
@devversion @kara
fix(bazel): protractor utils cannot start server on windows (#27915)
9e04284 
* Currently the protractor utils assume that the specified Bazel server runfile can be resolved by just using the real file system. This is not the case on Windows because the runfiles are not symlinked into the working directory and need to be resolved through the runfile manifest.

PR Close #27915
@kara kara closed this in 9de9c8a Jan 7, 2019
devversion added a commit to devversion/angular that referenced this pull request Jan 9, 2019
@devversion
fix(bazel): protractor utils cannot start server on windows (angular#…
607fad7 
…27915)

* Currently the protractor utils assume that the specified Bazel server runfile can be resolved by just using the real file system. This is not the case on Windows because the runfiles are not symlinked into the working directory and need to be resolved through the runfile manifest.

PR Close angular#27915
AndrewKushnir pushed a commit that referenced this pull request Jan 16, 2019
@devversion @AndrewKushnir
fix(bazel): protractor utils cannot start server on windows (#27915)
0be8487 
* Currently the protractor utils assume that the specified Bazel server runfile can be resolved by just using the real file system. This is not the case on Windows because the runfiles are not symlinked into the working directory and need to be resolved through the runfile manifest.

PR Close #27915
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@devversion @ngfelixl
fix(bazel): protractor utils cannot start server on windows (angular#…
41fff46 
…27915)

* Currently the protractor utils assume that the specified Bazel server runfile can be resolved by just using the real file system. This is not the case on Windows because the runfiles are not symlinked into the working directory and need to be resolved through the runfile manifest.

PR Close angular#27915
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak

@alexeagle alexeagle

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes hotlist: components team Related to Angular CDK or Angular Material target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@devversion @mary-poppins @AndrewKushnir @alexeagle @gkalpak @googlebot