fix(bazel): Bazel schematics should add router package #28141
Closed
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
added
target: patch
|
You can preview 4866373 at https://pr28141-4866373.ngbuilds.io/. |
This commit fixes a bug whereby a Bazel project created by the schematics would not compiled if project contains routing module. It is missing a dependency on the router package.
mgechev
approved these changes
Jan 14, 2019
|
You can preview da6a256 at https://pr28141-da6a256.ngbuilds.io/. |
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 15, 2019
This commit fixes a bug whereby a Bazel project created by the schematics would not compiled if project contains routing module. It is missing a dependency on the router package. PR Close #28141
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 16, 2019
This commit fixes a bug whereby a Bazel project created by the schematics would not compiled if project contains routing module. It is missing a dependency on the router package. PR Close #28141
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Jan 18, 2019
This commit fixes a bug whereby a Bazel project created by the schematics would not compiled if project contains routing module. It is missing a dependency on the router package. PR Close angular#28141
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Jan 18, 2019
This commit fixes a bug whereby a Bazel project created by the schematics would not compiled if project contains routing module. It is missing a dependency on the router package. PR Close angular#28141
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
This commit fixes a bug whereby a Bazel project created by the schematics would not compiled if project contains routing module. It is missing a dependency on the router package. PR Close angular#28141
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug whereby a Bazel project created by the
schematics would not compiled if project contains routing module.
It is missing a dependency on the router package.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information