Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): removed obsolete TODO comment #29085

Closed
wants to merge 1 commit into from

Conversation

Maxim-Mazurok
Copy link
Contributor

@Maxim-Mazurok Maxim-Mazurok commented Mar 3, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

comment exists

What is the new behavior?

comment removed

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Per discussin in #29082 (review) and #29082 (comment), this PR removing obsolete comment which was originally added by @IgorMinar in #22573

@Maxim-Mazurok Maxim-Mazurok requested a review from a team as a code owner March 3, 2019 19:01
@brandonroberts brandonroberts added area: aio Related to the documentation effort1: hours target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR refactoring Issue that involves refactoring or code-cleanup labels Mar 4, 2019
@ngbot ngbot bot added this to the Backlog milestone Mar 4, 2019
@brandonroberts brandonroberts self-assigned this Mar 4, 2019
@brandonroberts
Copy link
Contributor

Caretaker note: This is a docs only change and should not impact g3. Please run presubmit.

@brandonroberts brandonroberts added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Mar 5, 2019
@ngbot ngbot bot added the action: merge The PR is ready for merge by the caretaker label Mar 5, 2019
AndrewKushnir pushed a commit that referenced this pull request Mar 5, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: aio Related to the documentation area: router cla: yes effort1: hours merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note refactoring Issue that involves refactoring or code-cleanup risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants