New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): HttpParams fromObject accepts ReadonlyArray<str… #31072
feat(common): HttpParams fromObject accepts ReadonlyArray<str… #31072
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
38ae83b
to
ba8159c
Compare
@MansourFall Can you update the commit message with |
ba8159c
to
0138e5c
Compare
@cexbrayat update done! thanks! |
@MansourFall Would you mind rebasing the PR to resolve the conflict? Basically keeping the new signature, but with the updated comment: /** Object map of the HTTP parameters. Mutually exclusive with `fromString`. */
fromObject?: {[param: string]: string | ReadonlyArray<string>}; To do so:
When that's done we should be able to merge it! |
0138e5c
to
d1a47c9
Compare
@cexbrayat thank you for the instructions, just made the changes! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…ing>
Fixes #28452
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #28452
What is the new behavior?
Does this PR introduce a breaking change?
Other information