ERROR in Symbol when compiling with Ivy in 9.0.0-next.2 #32166

116-7 · 2019-08-16T14:28:25Z

🐞 bug report

Affected Package

ngtsc

Is this a regression?

No

Description

When running normal production build with aot=true and Ivy disabled the build process completes successfully. Running with Ivy enabled results in the below error.

🔬 Minimal Reproduction

https://github.com/davidjeliba/angular-uirouterhybrid-ivy-issue
master branch uses 9.0.0-next.2

To setup/run:

Clone project
run "yarn"
run "yarn build:production" - aot=true, ivy=false - to show successful compilation
run "yarn build:production:ivy" - aot=true, ivy=true - produces the error

🔥 Exception or Error

WARNING in Unknown member type: "[key: string]: any;

ERROR in Symbol UIRouterModule declared in angular-uirouterhybrid-ivy-issue/node_modules/@uirouter/angular/lib/uiRouterNgModule.d.ts is not exported from @uirouter/angular-hybrid (import into angular-uirouterhybrid-ivy-issue/src/app/child.module.ts)

🌍 Your Environment

Angular Version:

Angular CLI: 8.3.0-rc.0
Node: 10.15.3
OS: darwin x64
Angular: 9.0.0-next.2
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router, upgrade

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.803.0-rc.0
@angular-devkit/build-angular     0.803.0-rc.0
@angular-devkit/build-optimizer   0.803.0-rc.0
@angular-devkit/build-webpack     0.803.0-rc.0
@angular-devkit/core              8.3.0-rc.0
@angular-devkit/schematics        8.3.0-rc.0
@angular/cli                      8.3.0-rc.0
@ngtools/webpack                  8.3.0-rc.0
@schematics/angular               8.3.0-rc.0
@schematics/update                0.803.0-rc.0
rxjs                              6.5.2
typescript                        3.4.5
webpack                           4.39.2

Anything else relevant?

The change @petebacondarwin made in #31342 seems to have removed the first unknown member type warning that was also present in the 8.1.0-rc.0 example.

WARNING in Unknown member type: "[key: string]: (data: any) => void;

WARNING in Unknown member type: "[key: string]: any;

ERROR in Symbol UIRouterModule declared in angular-uirouterhybrid-ivy-issue/node_modules/@uirouter/angular/lib/uiRouterNgModule.d.ts is not exported from @uirouter/angular-hybrid (import into angular-uirouterhybrid-ivy-issue/src/app/child.module.ts)

The text was updated successfully, but these errors were encountered:

116-7 · 2019-08-24T16:29:41Z

Still present in 9.0.0-next.3 - I have updated the example.

Also yarn build:production is now essentially the same command as yarn build:production:ivy in the example project now that Ivy is enabled by default as of next.3

116-7 · 2019-10-29T12:53:53Z

Tested on 9.0.0-next.18 and updated reproduction repo.

No warnings now, just the error as per first post.

116-7 · 2019-10-29T13:38:03Z

Probably not relevant at the moment to be an Angular issue.

@uirouter/angular issue tracking Ivy support is probably more relevant ui-router/angular#516

petebacondarwin · 2019-10-30T09:03:01Z

The ivy branch in the uirouter/angular repository does work with v9 now.
See ui-router/angular#516 (comment)

petebacondarwin · 2019-10-30T10:11:40Z

But I see that the original issue is with @ui-router/angular-hybrid not @ui-router/angular. so I am reopening this while I investigate.

petebacondarwin · 2019-10-30T15:15:19Z

This package has a separate issue from the uirouter/angular package. Working on a solution...

Previously declarations that were imported via a namespace import were given the same `bestGuessOwningModule` as the context where they were imported to. This causes problems with resolving `ModuleWithProviders` that have a type that has been imported in this way, causing errors like: ``` ERROR in Symbol UIRouterModule declared in .../@uirouter/angular/uiRouterNgModule.d.ts is not exported from .../@uirouter/angular/uirouter-angular.d.ts (import into .../src/app/child.module.ts) ``` This commit modifies the `TypescriptReflectionHost.getDirectImportOfIdentifier()` method so that it also understands how to attach the correct `viaModule` to the identifier of the namespace import. Resolves angular#32166

#33495) Previously declarations that were imported via a namespace import were given the same `bestGuessOwningModule` as the context where they were imported to. This causes problems with resolving `ModuleWithProviders` that have a type that has been imported in this way, causing errors like: ``` ERROR in Symbol UIRouterModule declared in .../@uirouter/angular/uiRouterNgModule.d.ts is not exported from .../@uirouter/angular/uirouter-angular.d.ts (import into .../src/app/child.module.ts) ``` This commit modifies the `TypescriptReflectionHost.getDirectImportOfIdentifier()` method so that it also understands how to attach the correct `viaModule` to the identifier of the namespace import. Resolves #32166 PR Close #33495

angular#33495) Previously declarations that were imported via a namespace import were given the same `bestGuessOwningModule` as the context where they were imported to. This causes problems with resolving `ModuleWithProviders` that have a type that has been imported in this way, causing errors like: ``` ERROR in Symbol UIRouterModule declared in .../@uirouter/angular/uiRouterNgModule.d.ts is not exported from .../@uirouter/angular/uirouter-angular.d.ts (import into .../src/app/child.module.ts) ``` This commit modifies the `TypescriptReflectionHost.getDirectImportOfIdentifier()` method so that it also understands how to attach the correct `viaModule` to the identifier of the namespace import. Resolves angular#32166 PR Close angular#33495

angular-automatic-lock-bot · 2019-12-01T16:11:05Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

AndrewKushnir added the comp: ngcc label Aug 16, 2019

ngbot bot added this to the needsTriage milestone Aug 16, 2019

alxhub added freq2: medium severity3: broken type: bug/fix labels Aug 20, 2019

ngbot bot modified the milestones: needsTriage, Backlog Aug 20, 2019

gkalpak mentioned this issue Oct 21, 2019

Failure tracking summary angular/ngcc-validation#386

Closed

45 tasks

116-7 closed this as completed Oct 29, 2019

petebacondarwin reopened this Oct 30, 2019

petebacondarwin mentioned this issue Oct 30, 2019

fix(compiler-cli): attach the correct viaModule to namespace imports #33495

Closed

atscott closed this as completed in 1d141a8 Oct 31, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ERROR in Symbol when compiling with Ivy in 9.0.0-next.2 #32166

ERROR in Symbol when compiling with Ivy in 9.0.0-next.2 #32166

116-7 commented Aug 16, 2019 •

edited

116-7 commented Aug 24, 2019

116-7 commented Oct 29, 2019

116-7 commented Oct 29, 2019

petebacondarwin commented Oct 30, 2019

petebacondarwin commented Oct 30, 2019

petebacondarwin commented Oct 30, 2019

angular-automatic-lock-bot bot commented Dec 1, 2019

ERROR in Symbol when compiling with Ivy in 9.0.0-next.2 #32166

ERROR in Symbol when compiling with Ivy in 9.0.0-next.2 #32166

Comments

116-7 commented Aug 16, 2019 • edited

🐞 bug report

Affected Package

Is this a regression?

Description

🔬 Minimal Reproduction

🔥 Exception or Error

🌍 Your Environment

116-7 commented Aug 24, 2019

116-7 commented Oct 29, 2019

116-7 commented Oct 29, 2019

petebacondarwin commented Oct 30, 2019

petebacondarwin commented Oct 30, 2019

petebacondarwin commented Oct 30, 2019

angular-automatic-lock-bot bot commented Dec 1, 2019

116-7 commented Aug 16, 2019 •

edited