fix(service-worker): ensure initialization before handling messages #32525

Splaktar · 2019-09-07T04:01:29Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Service workers can fail after updates with the exception: Invariant violated (initialize): latest hash null has no known manifest.

Issue Number:
Fixes #25611

What is the new behavior?

community members with this issue have tested this fix
- @hsta verified that users have not seen the issue with this fix
  through all of August

Does this PR introduce a breaking change?

Yes
No

Other information

Fix suggested by @gkalpak. Similar code can be found in Driver.handleFetch().

gkalpak

Thx for taking this on, @Splaktar ❤️
I have left a couple of suggestions. We should also have some tests for this new behavior.

packages/service-worker/worker/src/driver.ts

paustint · 2019-09-19T14:09:05Z

@Splaktar #nudge :)

rebendajirijr · 2019-10-10T08:30:06Z

Will this be available in next release 9.0.0?

gkalpak · 2019-10-10T09:05:41Z

@rebendajirijr: Only if the PR is merged in time for the release 😉
@Splaktar: Are you still interested (and available) to move this forward?

Splaktar · 2019-10-10T21:09:27Z

@gkalpak yeah, I've just been busy with Ivy-related testing/fixes. I will try to get back to this soon. Feel free to take over if you have time to address it now.

Splaktar · 2019-10-26T01:33:55Z

I've added a test for handleFetch() where I could reproduce the issue in a test.

I haven't been able to reproduce the handleMessage() exception in a unit test. @gkalpak do you have any ideas there?

gkalpak · 2019-10-29T16:08:07Z

I have made some changes (including a test for onMessage() and rebasing on master) on my branch gkalpak:service-worker-invariant-violated, but for some reason I could not force-push to your branch 🤷‍♂

Could you port the changes over to your branch to update the PR, @Splaktar? 🙏

Splaktar · 2019-10-29T20:35:39Z

@gkalpak will do! I do have it set to allow edits from maintainers. So I'm not sure what the issue is, but I'll update ASAP, many thanks!

Splaktar · 2019-10-29T22:00:27Z

@gkalpak OK, changes applied. Fixed a typo or two. PTAL.

gkalpak

LGTM 🎉
Can you please update the commit message to not mention fetch (because this commit does not really affect how fetch is handled - initialization did already happen before fetch).

@gkalpak

- resolves "Invariant violated (initialize): latest hash null has no known manifest" - Thanks to @gkalpak and @hsta for helping test and investigate this fix Fixes angular#25611

Splaktar · 2019-10-30T23:23:13Z

@gkalpak done.

@gkalpak

…32525) - resolves "Invariant violated (initialize): latest hash null has no known manifest" - Thanks to @gkalpak and @hsta for helping test and investigate this fix Fixes #25611 PR Close #32525

@gkalpak

…ngular#32525) - resolves "Invariant violated (initialize): latest hash null has no known manifest" - Thanks to @gkalpak and @hsta for helping test and investigate this fix Fixes angular#25611 PR Close angular#32525

@gkalpak

…ngular#32525) - resolves "Invariant violated (initialize): latest hash null has no known manifest" - Thanks to @gkalpak and @hsta for helping test and investigate this fix Fixes angular#25611 PR Close angular#32525

@gkalpak

…ngular#32525) - resolves "Invariant violated (initialize): latest hash null has no known manifest" - Thanks to @gkalpak and @hsta for helping test and investigate this fix Fixes angular#25611 PR Close angular#32525

@gkalpak

…32525) - resolves "Invariant violated (initialize): latest hash null has no known manifest" - Thanks to @gkalpak and @hsta for helping test and investigate this fix Fixes #25611 PR Close #32525

angular-automatic-lock-bot · 2019-12-01T16:11:11Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

Splaktar requested a review from a team as a code owner September 7, 2019 04:01

googlebot added the cla: yes label Sep 7, 2019

Splaktar mentioned this pull request Sep 7, 2019

Service worker Invariant violated (initialize): latest hash null #25611

Closed

gkalpak requested changes Sep 7, 2019

View reviewed changes

packages/service-worker/worker/src/driver.ts Show resolved Hide resolved

packages/service-worker/worker/src/driver.ts Outdated Show resolved Hide resolved

matsko added the area: service-worker Issues related to the @angular/service-worker package label Sep 10, 2019

ngbot bot added this to the needsTriage milestone Sep 10, 2019

Splaktar force-pushed the service-worker-invariant-violated branch 4 times, most recently from 5c3a405 to 0132797 Compare October 26, 2019 01:22

Splaktar force-pushed the service-worker-invariant-violated branch from 0132797 to e653231 Compare October 29, 2019 21:12

gkalpak approved these changes Oct 30, 2019

View reviewed changes

gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release type: bug/fix labels Oct 30, 2019

fix(service-worker): ensure initialization before handling messages

afba739

- resolves "Invariant violated (initialize): latest hash null has no known manifest" - Thanks to @gkalpak and @hsta for helping test and investigate this fix Fixes angular#25611

Splaktar force-pushed the service-worker-invariant-violated branch from e653231 to afba739 Compare October 30, 2019 23:22

Splaktar changed the title ~~fix(service-worker): ensure initialization in handleMessage()~~ fix(service-worker): ensure initialization before handling messages Oct 30, 2019

gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 31, 2019

atscott closed this in 72eba77 Oct 31, 2019

gkalpak mentioned this pull request Nov 2, 2019

angular.io app gets stuck in “loading document” state, likely due to client-server version skew #28114

Closed

3 tasks

gkalpak mentioned this pull request Nov 11, 2019

[8.2.x] fix(service-worker): ensure initialization before handling messages #33744

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 1, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(service-worker): ensure initialization before handling messages #32525

fix(service-worker): ensure initialization before handling messages #32525

Splaktar commented Sep 7, 2019

gkalpak left a comment

paustint commented Sep 19, 2019

rebendajirijr commented Oct 10, 2019

gkalpak commented Oct 10, 2019

Splaktar commented Oct 10, 2019

Splaktar commented Oct 26, 2019

gkalpak commented Oct 29, 2019

Splaktar commented Oct 29, 2019 •

edited

Splaktar commented Oct 29, 2019

gkalpak left a comment

Splaktar commented Oct 30, 2019

angular-automatic-lock-bot bot commented Dec 1, 2019

fix(service-worker): ensure initialization before handling messages #32525

fix(service-worker): ensure initialization before handling messages #32525

Conversation

Splaktar commented Sep 7, 2019

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

gkalpak left a comment

Choose a reason for hiding this comment

paustint commented Sep 19, 2019

rebendajirijr commented Oct 10, 2019

gkalpak commented Oct 10, 2019

Splaktar commented Oct 10, 2019

Splaktar commented Oct 26, 2019

gkalpak commented Oct 29, 2019

Splaktar commented Oct 29, 2019 • edited

Splaktar commented Oct 29, 2019

gkalpak left a comment

Choose a reason for hiding this comment

Splaktar commented Oct 30, 2019

angular-automatic-lock-bot bot commented Dec 1, 2019

Splaktar commented Oct 29, 2019 •

edited