Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): fix typo in diagnostic template info #32684

Closed
wants to merge 1 commit into from

Conversation

cRAN-cg
Copy link
Contributor

@cRAN-cg cRAN-cg commented Sep 15, 2019

Closes #32662.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: 32662

What is the new behavior?

Explicit context reference error now reads
The template context does not define a member called

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@cRAN-cg
Copy link
Contributor Author

cRAN-cg commented Sep 15, 2019

@gkalpak can you please review.

@cRAN-cg cRAN-cg requested a review from a team as a code owner September 15, 2019 08:26
@cRAN-cg cRAN-cg force-pushed the issue#32662 branch 2 times, most recently from c0a97ec to e9ae21d Compare September 15, 2019 09:07
@cRAN-cg
Copy link
Contributor Author

cRAN-cg commented Sep 15, 2019

There seems to be some Chrome version mismatch which is responsible for failing some checks.
Also I had to make three commits to make a workable PR, need your advise if you would like me to squish it into one or submit a new PR itself.

@gkalpak gkalpak added area: compiler Issues related to `ngc`, Angular's template compiler state: WIP target: patch This PR is targeted for the next patch release type: bug/fix labels Sep 15, 2019
@ngbot ngbot bot modified the milestone: needsTriage Sep 15, 2019
@gkalpak
Copy link
Member

gkalpak commented Sep 15, 2019

Thx, @cRAN-cg 🎉
Can you please rebase on latest master (that should make CI green) and squash the commits into one. While you're at it, please also update the commit message to include Fixes #32662 (per our guidelines) 🙏

@cRAN-cg cRAN-cg force-pushed the issue#32662 branch 2 times, most recently from 95ade0b to e3ce203 Compare September 15, 2019 18:55
@cRAN-cg
Copy link
Contributor Author

cRAN-cg commented Sep 15, 2019

@gkalpak Thanks a ton for guiding me. Apologies for not abiding by the guidelines. Will keep that in mind for the next time. It's my first PR to angular so am really very excited  🤩. Thanks for your time and bearing with me. 👍 Thanks again 😊

@gkalpak
Copy link
Member

gkalpak commented Sep 16, 2019

No worries, @cRAN-cg! Thx for fixing it up 👍
It looks good to me, but someone from the fw-compiler and tools-language-service team needs to approve it too.

(BTW, test(language-service): fix typo in diagnostic template info. could be removed from the commit message, but is not a blocker.)

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed state: WIP labels Sep 16, 2019
@cRAN-cg
Copy link
Contributor Author

cRAN-cg commented Sep 16, 2019

(BTW, test(language-service): fix typo in diagnostic template info. could be removed from the commit message, but is not a blocker.)

Done sire 🛠

Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara
Copy link
Contributor

kara commented Sep 16, 2019

merge-assistance: global approval

@kara kara closed this in f6d6667 Sep 16, 2019
kara pushed a commit that referenced this pull request Sep 16, 2019
arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2019
@cRAN-cg cRAN-cg deleted the issue#32662 branch July 30, 2020 01:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler cla: yes target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in diagnostic template info
4 participants