New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bazel): ng_package(data) should support non-text files #32721
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, nice job finding a way to test it
@jbedard thanks for the PR! Could you please have a look at the lint error here: https://circleci.com/gh/angular/angular/459499 Thank you. |
@alexeagle should this PR go into master only or master and patch? |
a674a85
to
a83c4fd
Compare
Fixed 🤞 Would be great if this was in a patch release... |
Thanks @jbedard and @alexeagle, this PR is now merged into master and patch branches. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Today non-text
ng_package(data)
files might (always?) get corrupted because they get read+written as utf8, for example font or image files.I think the
utf8
will be used by default for non-binary files, so the param is not needed at all?PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
The bazel
ng_package(data)
now supports non-utf8 files.Does this PR introduce a breaking change?
Other information