Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): ng_package(data) should support non-text files #32721

Closed
wants to merge 1 commit into from

Conversation

jbedard
Copy link
Contributor

@jbedard jbedard commented Sep 17, 2019

Today non-text ng_package(data) files might (always?) get corrupted because they get read+written as utf8, for example font or image files.

I think the utf8 will be used by default for non-binary files, so the param is not needed at all?

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

The bazel ng_package(data) now supports non-utf8 files.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jbedard jbedard requested a review from a team as a code owner September 17, 2019 16:38
Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, nice job finding a way to test it

@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Sep 17, 2019
@AndrewKushnir AndrewKushnir added the area: bazel Issues related to the published `@angular/bazel` build rules label Sep 17, 2019
@ngbot ngbot bot added this to the needsTriage milestone Sep 17, 2019
@AndrewKushnir AndrewKushnir added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Sep 17, 2019
@AndrewKushnir
Copy link
Contributor

@jbedard thanks for the PR! Could you please have a look at the lint error here:

https://circleci.com/gh/angular/angular/459499

Thank you.

@AndrewKushnir
Copy link
Contributor

@alexeagle should this PR go into master only or master and patch?

@jbedard
Copy link
Contributor Author

jbedard commented Sep 17, 2019

Fixed 🤞

Would be great if this was in a patch release...

@alexeagle alexeagle added target: patch This PR is targeted for the next patch release and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 17, 2019
@AndrewKushnir
Copy link
Contributor

Thanks @jbedard and @alexeagle, this PR is now merged into master and patch branches.

arnehoek pushed a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants