fix(ivy): ensure overrides for 'multi: true' only appear once in final providers #33104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Presubmit |
AndrewKushnir
requested changes
Oct 11, 2019
There was a problem hiding this comment.
@atscott thanks for the fix! I left a few comments. Thank you.
AndrewKushnir
added
comp: ivy
area: testing
atscott
force-pushed
the
multiProviders
branch
from
b98a95f
to
69b674d
Compare
AndrewKushnir
approved these changes
Oct 11, 2019
atscott
added
action: merge
atscott
force-pushed
the
multiProviders
branch
2 times, most recently
from
c7cedcb
to
8255771
Compare
…in final providers
…in final providers
…in final providers
atscott
force-pushed
the
multiProviders
branch
from
d89682d
to
bc8b418
Compare
AndrewKushnir
approved these changes
Oct 21, 2019
…in final providers
atscott
force-pushed
the
multiProviders
branch
from
1092aea
to
1cd2b43
Compare
atscott
force-pushed
the
multiProviders
branch
3 times, most recently
from
4aef656
to
19a9e1b
Compare
atscott
force-pushed
the
multiProviders
branch
2 times, most recently
from
c8e19ca
to
7e11882
Compare
…in final providers
atscott
force-pushed
the
multiProviders
branch
from
7e11882
to
e703834
Compare
…in final providers
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
…l providers (angular#33104) PR Close angular#33104
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
…l providers (angular#33104) PR Close angular#33104
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, if you override a provider with
mutli: true, the TestBed goes through and overrides each place where the token is provided. Then the injector processes all of them and adds each occurrence to the provider records. As a result, if you override amulti: trueprovider, you get too many instances in the final output. You should only get the one that was provided in the override (see the test in this PR).