refactor(core): various fixes for missing-injectable migration #33286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
action: review
devversion
force-pushed
the
refactor/core-missing-injectable-forward-ref
branch
from
02c4c04
to
ad5a3c6
Compare
devversion
force-pushed
the
refactor/core-missing-injectable-forward-ref
branch
2 times, most recently
from
246f661
to
a80d60b
Compare
devversion
changed the title
devversion
force-pushed
the
refactor/core-missing-injectable-forward-ref
branch
2 times, most recently
from
e6e6d58
to
483c4d4
Compare
alxhub
approved these changes
Oct 24, 2019
| @@ -6,6 +6,7 @@ | |||
| * found in the LICENSE file at https://angular.io/license | |||
| */ | |||
|
|
|||
| import {forwardRefResolver} from '@angular/compiler-cli/src/ngtsc/annotations/src/util'; | |||
There was a problem hiding this comment.
We really need to put this in a better place...
There was a problem hiding this comment.
Agreed. It currently is somewhat odd to import from the annotations build package.
Currently the migration is unable to migrate instances where the provider definition uses `forwardRef`. Since this is a common pattern, we should support that from within the migration. The solution to the problem is adding a foreign function resolver to the `PartialEvaluator`. This basically matches the usage of the static evaluation that is used by the ngtsc annotations.
…with "useExisting" We should not migrate the reference from `useExisting`. This is because developers can only use the `useExisting` value as a token. e.g. ```ts @NgModule({ providers: [ {provide: AppRippleConfig, useValue: rippleOptions}, {provide: MAT_RIPPLE_OPTIONS, useExisting: AppRippleConfig}, ] }) export class AppModule {} ``` In the case above, nothing should be decorated with `@Injectable`. The `AppRippleConfig` class is just used as a token for injection.
…tions Currently the `missing-injectable` migration seems to add `@Injectable()` to third-party classes in type definitions. This not an issue in general since we do not generate broken code by inserting a decorator into a type definition file. Though, we can avoid adding the decorator since it won't have any effect and in general we should not write to non source files of the compilation unit.
devversion
force-pushed
the
refactor/core-missing-injectable-forward-ref
branch
from
483c4d4
to
4656cae
Compare
devversion
added
action: merge
AndrewKushnir
added
the
action: presubmit
|
FYI, g3 presubmit looks good. |
AndrewKushnir
removed
the
action: presubmit
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 25, 2019
…with "useExisting" (#33286) We should not migrate the reference from `useExisting`. This is because developers can only use the `useExisting` value as a token. e.g. ```ts @NgModule({ providers: [ {provide: AppRippleConfig, useValue: rippleOptions}, {provide: MAT_RIPPLE_OPTIONS, useExisting: AppRippleConfig}, ] }) export class AppModule {} ``` In the case above, nothing should be decorated with `@Injectable`. The `AppRippleConfig` class is just used as a token for injection. PR Close #33286
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 25, 2019
…tions (#33286) Currently the `missing-injectable` migration seems to add `@Injectable()` to third-party classes in type definitions. This not an issue in general since we do not generate broken code by inserting a decorator into a type definition file. Though, we can avoid adding the decorator since it won't have any effect and in general we should not write to non source files of the compilation unit. PR Close #33286
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.