Directive instance refactor #33322
Closed
Directive instance refactor #33322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
added
target: major
pkozlowski-opensource
force-pushed
the
directive_instance_refactor
branch
from
202478b
to
6d5e0b8
Compare
Yay :-) |
Before this change instantiating multiple directives on the same host node would result in repeated RNode retrieval and patching. This commint re-organises code around directive instance creation so the host node processing (common to all directives) happens once and only once. As the additional benefit the directive instantiation logic gets centralised in one function (at the expense of patching logic duplication for root node).
pkozlowski-opensource
force-pushed
the
directive_instance_refactor
branch
from
6d5e0b8
to
09e96cd
Compare
pkozlowski-opensource
force-pushed
the
directive_instance_refactor
branch
from
09e96cd
to
bc73ebe
Compare
kara
added
action: cleanup
Co-Authored-By: Kara <kara@users.noreply.github.com>
pkozlowski-opensource
added
action: merge
AndrewKushnir
added
target: patch
atscott
pushed a commit
that referenced
this pull request
Oct 31, 2019
atscott
pushed a commit
that referenced
this pull request
Oct 31, 2019
Before this change instantiating multiple directives on the same host node would result in repeated RNode retrieval and patching. This commint re-organises code around directive instance creation so the host node processing (common to all directives) happens once and only once. As the additional benefit the directive instantiation logic gets centralised in one function (at the expense of patching logic duplication for root node). PR Close #33322
atscott
pushed a commit
that referenced
this pull request
Oct 31, 2019
atscott
pushed a commit
that referenced
this pull request
Oct 31, 2019
Before this change instantiating multiple directives on the same host node would result in repeated RNode retrieval and patching. This commint re-organises code around directive instance creation so the host node processing (common to all directives) happens once and only once. As the additional benefit the directive instantiation logic gets centralised in one function (at the expense of patching logic duplication for root node). PR Close #33322
atscott
pushed a commit
that referenced
this pull request
Oct 31, 2019
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
…nentDef checks (angular#33322) PR Close angular#33322
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
…#33322) Before this change instantiating multiple directives on the same host node would result in repeated RNode retrieval and patching. This commint re-organises code around directive instance creation so the host node processing (common to all directives) happens once and only once. As the additional benefit the directive instantiation logic gets centralised in one function (at the expense of patching logic duplication for root node). PR Close angular#33322
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
…nentDef checks (angular#33322) PR Close angular#33322
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
…#33322) Before this change instantiating multiple directives on the same host node would result in repeated RNode retrieval and patching. This commint re-organises code around directive instance creation so the host node processing (common to all directives) happens once and only once. As the additional benefit the directive instantiation logic gets centralised in one function (at the expense of patching logic duplication for root node). PR Close angular#33322
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.