Ngtsc/ttc/strict #33365

alxhub · 2019-10-23T21:44:09Z

Takeover of #33273 for faster round trips.

googlebot · 2019-10-23T21:44:12Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2019-10-24T01:17:48Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2019-10-24T01:20:02Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2019-10-24T15:04:53Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

alxhub · 2019-10-24T15:12:15Z

Presubmit

googlebot · 2019-10-24T16:17:35Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2019-10-24T16:36:45Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

kara

LGTM, some minor nits in comments

packages/compiler-cli/src/ngtsc/typecheck/src/api.ts

packages/compiler-cli/src/transformers/api.ts

googlebot · 2019-10-24T22:16:49Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

ngbot · 2019-10-24T22:17:17Z

I see that you just added the PR action: merge label, but the following checks are still failing:
     status "ci/angular: size" is failing
     status "ci/circleci: test" is failing
     status "ci/circleci: test_ivy_aot" is failing
     forbidden labels detected: PR action: cleanup
     status "ci/circleci: integration_test" is pending
     status "ci/circleci: test_aio_local" is pending
     status "ci/circleci: test_aio_local_viewengine" is pending
     status "ci/circleci: test_docs_examples" is pending
     status "ci/circleci: test_docs_examples_ivy" is pending
     status "google3" is pending
     missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

For elements that have a text attribute, it may happen that the element is matched by a directive that consumes the attribute as an input. In that case, the template type checker will validate the correctness of the attribute with respect to the directive's declared type of the input, which would typically be `boolean` for the `disabled` input. Since empty attributes are assigned the empty string at runtime, the template type checker would report an error for this template. This commit introduces a strictness flag to help alleviate this particular situation, effectively ignoring text attributes that happen to be consumed by a directive.

View Engine correctly infers the type of local refs to directives or to <ng-template>s, just not to DOM nodes. This commit splits the checkTypeOfReferences flag into two separate halves, allowing the compiler to align with this behavior.

The template type checking abilities of the Ivy compiler are far more advanced than the level of template type checking that was previously done for Angular templates. Up until now, a single compiler option called "fullTemplateTypeCheck" was available to configure the level of template type checking. However, now that more advanced type checking is being done, new errors may surface that were previously not reported, in which case it may not be feasible to fix all new errors at once. Having only a single option to disable a large number of template type checking capabilities does not allow for incrementally addressing newly reported types of errors. As a solution, this commit introduces some new compiler options to be able to enable/disable certain kinds of template type checks on a fine-grained basis.

googlebot · 2019-10-24T22:32:42Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2019-10-24T22:33:14Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

…3365) View Engine correctly infers the type of local refs to directives or to <ng-template>s, just not to DOM nodes. This commit splits the checkTypeOfReferences flag into two separate halves, allowing the compiler to align with this behavior. PR Close #33365

The template type checking abilities of the Ivy compiler are far more advanced than the level of template type checking that was previously done for Angular templates. Up until now, a single compiler option called "fullTemplateTypeCheck" was available to configure the level of template type checking. However, now that more advanced type checking is being done, new errors may surface that were previously not reported, in which case it may not be feasible to fix all new errors at once. Having only a single option to disable a large number of template type checking capabilities does not allow for incrementally addressing newly reported types of errors. As a solution, this commit introduces some new compiler options to be able to enable/disable certain kinds of template type checks on a fine-grained basis. PR Close #33365

…3365) For elements that have a text attribute, it may happen that the element is matched by a directive that consumes the attribute as an input. In that case, the template type checker will validate the correctness of the attribute with respect to the directive's declared type of the input, which would typically be `boolean` for the `disabled` input. Since empty attributes are assigned the empty string at runtime, the template type checker would report an error for this template. This commit introduces a strictness flag to help alleviate this particular situation, effectively ignoring text attributes that happen to be consumed by a directive. PR Close angular#33365

…gular#33365) View Engine correctly infers the type of local refs to directives or to <ng-template>s, just not to DOM nodes. This commit splits the checkTypeOfReferences flag into two separate halves, allowing the compiler to align with this behavior. PR Close angular#33365

The template type checking abilities of the Ivy compiler are far more advanced than the level of template type checking that was previously done for Angular templates. Up until now, a single compiler option called "fullTemplateTypeCheck" was available to configure the level of template type checking. However, now that more advanced type checking is being done, new errors may surface that were previously not reported, in which case it may not be feasible to fix all new errors at once. Having only a single option to disable a large number of template type checking capabilities does not allow for incrementally addressing newly reported types of errors. As a solution, this commit introduces some new compiler options to be able to enable/disable certain kinds of template type checks on a fine-grained basis. PR Close angular#33365

angular-automatic-lock-bot · 2019-11-24T16:11:04Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: no label Oct 23, 2019

alxhub mentioned this pull request Oct 23, 2019

feat(ivy): strictness flags for template type checking #33273

Closed

alxhub force-pushed the ngtsc/ttc/strict branch 3 times, most recently from 140e771 to 4914800 Compare October 24, 2019 01:17

alxhub added cla: yes and removed cla: no labels Oct 24, 2019

alxhub force-pushed the ngtsc/ttc/strict branch from 4914800 to 899c6ee Compare October 24, 2019 01:19

googlebot added cla: no and removed cla: yes labels Oct 24, 2019

alxhub added cla: yes and removed cla: no labels Oct 24, 2019

alxhub marked this pull request as ready for review October 24, 2019 15:12

alxhub requested a review from a team as a code owner October 24, 2019 15:12

alxhub added the target: major This PR is targeted for the next major release label Oct 24, 2019

alxhub force-pushed the ngtsc/ttc/strict branch from 899c6ee to 24fd54c Compare October 24, 2019 16:17

googlebot added cla: no and removed cla: yes labels Oct 24, 2019

alxhub added cla: yes and removed cla: no labels Oct 24, 2019

kara approved these changes Oct 24, 2019

View reviewed changes

kara added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 24, 2019

kara assigned alxhub Oct 24, 2019

alxhub added cla: yes and removed cla: no labels Oct 24, 2019

alxhub added the action: merge The PR is ready for merge by the caretaker label Oct 24, 2019

JoostK and others added 3 commits October 24, 2019 15:19

alxhub force-pushed the ngtsc/ttc/strict branch from a287925 to ce3457c Compare October 24, 2019 22:32

googlebot added cla: no and removed cla: yes labels Oct 24, 2019

alxhub added cla: yes and removed cla: no labels Oct 24, 2019

alxhub added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Oct 24, 2019

AndrewKushnir closed this in d8ce212 Oct 24, 2019

asapach mentioned this pull request Oct 28, 2019

ivy: Boolean inputs cause compile errors angular/components#17495

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ngtsc/ttc/strict #33365

Ngtsc/ttc/strict #33365

alxhub commented Oct 23, 2019

googlebot commented Oct 23, 2019

googlebot commented Oct 24, 2019

googlebot commented Oct 24, 2019

googlebot commented Oct 24, 2019

alxhub commented Oct 24, 2019

googlebot commented Oct 24, 2019

googlebot commented Oct 24, 2019

kara left a comment

googlebot commented Oct 24, 2019

ngbot bot commented Oct 24, 2019

googlebot commented Oct 24, 2019

googlebot commented Oct 24, 2019

angular-automatic-lock-bot bot commented Nov 24, 2019

Ngtsc/ttc/strict #33365

Ngtsc/ttc/strict #33365

Conversation

alxhub commented Oct 23, 2019

googlebot commented Oct 23, 2019

googlebot commented Oct 24, 2019

googlebot commented Oct 24, 2019

googlebot commented Oct 24, 2019

alxhub commented Oct 24, 2019

googlebot commented Oct 24, 2019

googlebot commented Oct 24, 2019

kara left a comment

Choose a reason for hiding this comment

googlebot commented Oct 24, 2019

ngbot bot commented Oct 24, 2019

googlebot commented Oct 24, 2019

googlebot commented Oct 24, 2019

angular-automatic-lock-bot bot commented Nov 24, 2019