Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): fix broken typechecking test on Windows #33376

Closed
wants to merge 1 commit into from

Conversation

alxhub
Copy link
Member

@alxhub alxhub commented Oct 24, 2019

One of the template type-checking tests relies on the newline character,
which is different on Windows. This commit fixes the issue.

One of the template type-checking tests relies on the newline character,
which is different on Windows. This commit fixes the issue.
@alxhub alxhub requested a review from a team as a code owner October 24, 2019 17:54
@AndrewKushnir AndrewKushnir added comp: ivy action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Oct 24, 2019
@ngbot ngbot bot modified the milestone: needsTriage Oct 24, 2019
@@ -159,7 +159,7 @@ TestClass.ngTypeCtor({value: 'test'});
const TestClassWithCtor =
getDeclaration(res.program, _('/main.ts'), 'TestClass', isNamedClassDeclaration);
const typeCtor = TestClassWithCtor.members.find(isTypeCtor) !;
const ctorText = typeCtor.getText().replace(/[ \n]+/g, ' ');
const ctorText = typeCtor.getText().replace(/[ \r\n]+/g, ' ');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want \r?\n instead, so it doesn't break on linux now. nvm I thought it was a capturing group.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants