New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ivy): handle elements with local refs in i18n blocks #33415
Closed
AndrewKushnir
wants to merge
2
commits into
angular:master
from
AndrewKushnir:FW-1642_i18n_local_refs
Closed
fix(ivy): handle elements with local refs in i18n blocks #33415
AndrewKushnir
wants to merge
2
commits into
angular:master
from
AndrewKushnir:FW-1642_i18n_local_refs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
action: review
The PR is still awaiting reviews from at least one requested reviewer
target: major
This PR is targeted for the next major release
labels
Oct 26, 2019
mhevery
approved these changes
Oct 28, 2019
mhevery
added
action: cleanup
The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
Oct 28, 2019
Prior to this commit, i18n logic which ensures that elements removed in a translation are also removed in DOM, didn't take into account the fact that elements may have local refs. As a result, remove operation failed, since there is no corresponding tNode found. This commit updates the logic to skip all local refs while going though the list of nodes to ensure that DOM matches elements present in translation.
AndrewKushnir
force-pushed
the
FW-1642_i18n_local_refs
branch
from
October 29, 2019 00:15
8adb68f
to
0b3ad9d
Compare
AndrewKushnir
added
action: presubmit
The PR is in need of a google3 presubmit
and removed
action: cleanup
The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews
labels
Oct 29, 2019
AndrewKushnir
added
action: merge
The PR is ready for merge by the caretaker
and removed
action: presubmit
The PR is in need of a google3 presubmit
labels
Oct 29, 2019
matsko
pushed a commit
to matsko/angular
that referenced
this pull request
Oct 30, 2019
Prior to this commit, i18n logic which ensures that elements removed in a translation are also removed in DOM, didn't take into account the fact that elements may have local refs. As a result, remove operation failed, since there is no corresponding tNode found. This commit updates the logic to skip all local refs while going though the list of nodes to ensure that DOM matches elements present in translation. PR Close angular#33415
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
Prior to this commit, i18n logic which ensures that elements removed in a translation are also removed in DOM, didn't take into account the fact that elements may have local refs. As a result, remove operation failed, since there is no corresponding tNode found. This commit updates the logic to skip all local refs while going though the list of nodes to ensure that DOM matches elements present in translation. PR Close angular#33415
mohaxspb
pushed a commit
to mohaxspb/angular
that referenced
this pull request
Nov 7, 2019
Prior to this commit, i18n logic which ensures that elements removed in a translation are also removed in DOM, didn't take into account the fact that elements may have local refs. As a result, remove operation failed, since there is no corresponding tNode found. This commit updates the logic to skip all local refs while going though the list of nodes to ensure that DOM matches elements present in translation. PR Close angular#33415
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: i18n
cla: yes
target: major
This PR is targeted for the next major release
type: bug/fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, i18n logic which ensures that elements removed in a translation are also removed in DOM, didn't take into account the fact that elements may have local refs. As a result, remove operation failed, since there is no corresponding tNode found. This commit updates the logic to skip all local refs while going though the list of nodes to ensure that DOM matches elements present in translation.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?