Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ivy): avoid generating selectors array for directives without a selector #33431

Closed

Conversation

crisbeto
Copy link
Member

Now that we've replaced ngBaseDef with an abstract directive definition, there are a lot more cases where we generate a directive definition without a selector. These changes make it so that we don't generate the selectors array if it's going to be empty.

…selector

Now that we've replaced `ngBaseDef` with an abstract directive definition, there are a lot more cases where we generate a directive definition without a selector. These changes make it so that we don't generate the `selectors` array if it's going to be empty.
@crisbeto crisbeto added comp: ivy action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Oct 27, 2019
@ngbot ngbot bot added this to the needsTriage milestone Oct 27, 2019
@crisbeto crisbeto marked this pull request as ready for review October 27, 2019 10:24
@crisbeto crisbeto requested review from a team as code owners October 27, 2019 10:24
function getStylingPrefix(name: string): string {
return name.substring(0, 5); // style or class
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this just dead-code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's been there for a while so I decided to clean it up.

@crisbeto crisbeto added action: presubmit The PR is in need of a google3 presubmit and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 28, 2019
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Oct 28, 2019

@AndrewKushnir AndrewKushnir removed the action: presubmit The PR is in need of a google3 presubmit label Oct 29, 2019
@AndrewKushnir
Copy link
Contributor

@crisbeto FYI, VE and Ivy presubmits are successful for this PR. Feel free to add "merge" label if it's ready to be merged. Thank you.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 29, 2019
matsko pushed a commit to matsko/angular that referenced this pull request Oct 30, 2019
…selector (angular#33431)

Now that we've replaced `ngBaseDef` with an abstract directive definition, there are a lot more cases where we generate a directive definition without a selector. These changes make it so that we don't generate the `selectors` array if it's going to be empty.

PR Close angular#33431
mohaxspb pushed a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
…selector (angular#33431)

Now that we've replaced `ngBaseDef` with an abstract directive definition, there are a lot more cases where we generate a directive definition without a selector. These changes make it so that we don't generate the `selectors` array if it's going to be empty.

PR Close angular#33431
mohaxspb pushed a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
…selector (angular#33431)

Now that we've replaced `ngBaseDef` with an abstract directive definition, there are a lot more cases where we generate a directive definition without a selector. These changes make it so that we don't generate the `selectors` array if it's going to be empty.

PR Close angular#33431
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants