New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler): i18n - ignore alt-trans
tags in XLIFF 1.2
#33450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I don't think the right approach is to ignore alt-trans, it should be to ignore any target tag that isn't a direct descendant of "trans-unit" (if it is in fact always a direct descendant? that's to confirm) |
@ocombe - I agree that the best way is to only consider But for the old It is the case that the |
The parser was accidentally reading the `target` tag below the `alt-trans` target and overriding the correct `target` tag. (This already worked in `$localize` but a test has been added to confirm.) Fixes angular#33161
0e6146d
to
6f0d461
Compare
…3450) The parser was accidentally reading the `target` tag below the `alt-trans` target and overriding the correct `target` tag. (This already worked in `$localize` but a test has been added to confirm.) Fixes angular#33161 PR Close angular#33450
…3450) The parser was accidentally reading the `target` tag below the `alt-trans` target and overriding the correct `target` tag. (This already worked in `$localize` but a test has been added to confirm.) Fixes angular#33161 PR Close angular#33450
…3450) The parser was accidentally reading the `target` tag below the `alt-trans` target and overriding the correct `target` tag. (This already worked in `$localize` but a test has been added to confirm.) Fixes angular#33161 PR Close angular#33450
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The parser was accidentally reading the
target
tagbelow the
alt-trans
target and overriding the correcttarget
tag.(This already worked in
$localize
but a test has beenadded to confirm.)
Fixes #33161
This needs to be merged to patch as well, but I don't think will go cleanly because of the
$localize
test.So I will create a new PR for patch once this has been approved.